Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1631528

[PATCH] gpio: f7188x: add missing break in switch statement

From Colin King <colin.king@canonical.com>
Newsgroups linux.kernel
Subject [PATCH] gpio: f7188x: add missing break in switch statement
Date 2017-04-26 17:30 +0200
Message-ID <tAx3e-46S-51@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


From: Colin Ian King <colin.king@canonical.com>

The case statement for f71889a is missing a break statement, add it.

Detected with CoverityScan, CID#1431861 ("Missig break in switch")

Fixes: d69843e416d31 ("gpio: f7188x: Add F71889A GPIO support.")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/gpio/gpio-f7188x.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpio/gpio-f7188x.c b/drivers/gpio/gpio-f7188x.c
index c013ff5deb70..13350c9d7f5e 100644
--- a/drivers/gpio/gpio-f7188x.c
+++ b/drivers/gpio/gpio-f7188x.c
@@ -398,6 +398,7 @@ static int f7188x_gpio_probe(struct platform_device *pdev)
 	case f71889a:
 		data->nr_bank = ARRAY_SIZE(f71889a_gpio_bank);
 		data->bank = f71889a_gpio_bank;
+		break;
 	case f71889f:
 		data->nr_bank = ARRAY_SIZE(f71889_gpio_bank);
 		data->bank = f71889_gpio_bank;
-- 
2.11.0

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[PATCH] gpio: f7188x: add missing break in switch statement Colin King <colin.king@canonical.com> - 2017-04-26 17:30 +0200

csiph-web