Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1631495
| From | Radim Krčmář <rkrcmar@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: kernel/rcu/tree.c:1031 rcu_irq_enter() invoked with irqs enabled!!!! |
| Date | 2017-04-26 16:50 +0200 |
| Message-ID | <tAwqt-3Ay-5@gated-at.bofh.it> (permalink) |
| References | <tAf6i-Vi-23@gated-at.bofh.it> <tAffY-Yq-31@gated-at.bofh.it> <tApoZ-7rG-7@gated-at.bofh.it> <tAvXr-3oc-5@gated-at.bofh.it> <tAwgO-3vw-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
2017-04-26 16:29+0200, Paolo Bonzini: > On 26/04/2017 16:18, Radim Krčmář wrote: >>> OK, but looking at the stack trace, this has nothing to do with ext4. The >>> problem seems to be in KVM - relevant CCs added. >> The path begins with async_page_fault interrupt gate and the hardware >> should clear the interrupt flag before executing it. I don't see a >> change that would break the assumption that interrupts are disabled ... > > native_safe_halt enables interrupts. I think this is it: > > diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c > index 14f65a5f938e..2a7835932b71 100644 > --- a/arch/x86/kernel/kvm.c > +++ b/arch/x86/kernel/kvm.c > @@ -161,8 +161,8 @@ void kvm_async_pf_task_wait(u32 token) > */ > rcu_irq_exit(); > native_safe_halt(); > - rcu_irq_enter(); > local_irq_disable(); > + rcu_irq_enter(); > } > } > if (!n.halted) We called rcu_irq_enter() there twice, *facepalm*. Yes, that patch should fix it.
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
kernel/rcu/tree.c:1031 rcu_irq_enter() invoked with irqs enabled!!!! Ross Zwisler <ross.zwisler@linux.intel.com> - 2017-04-25 22:20 +0200
Re: kernel/rcu/tree.c:1031 rcu_irq_enter() invoked with irqs enabled!!!! "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-04-25 22:30 +0200
Re: kernel/rcu/tree.c:1031 rcu_irq_enter() invoked with irqs enabled!!!! Jan Kara <jack@suse.cz> - 2017-04-26 09:20 +0200
Re: kernel/rcu/tree.c:1031 rcu_irq_enter() invoked with irqs enabled!!!! Radim Krčmář <rkrcmar@redhat.com> - 2017-04-26 16:20 +0200
Re: kernel/rcu/tree.c:1031 rcu_irq_enter() invoked with irqs enabled!!!! Paolo Bonzini <pbonzini@redhat.com> - 2017-04-26 16:40 +0200
Re: kernel/rcu/tree.c:1031 rcu_irq_enter() invoked with irqs enabled!!!! Radim Krčmář <rkrcmar@redhat.com> - 2017-04-26 16:50 +0200
csiph-web