Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1631501

Re: [PATCH v2 1/1] gpio: gpio-wcove: fix GPIO IRQ status mask

Path csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From Mika Westerberg <mika.westerberg@linux.intel.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2 1/1] gpio: gpio-wcove: fix GPIO IRQ status mask
Date Wed, 26 Apr 2017 17:00:01 +0200
Message-ID <tAwA9-3Ev-1@gated-at.bofh.it> (permalink)
References <ty4I2-80K-19@gated-at.bofh.it> <tzRGF-2y4-19@gated-at.bofh.it> <tAw77-3rU-11@gated-at.bofh.it>
X-Original-To Linus Walleij <linus.walleij@linaro.org>
X-Extloop1 1
X-Ironport-Av E=Sophos;i="5.37,254,1488873600"; d="scan'208";a="79165457"
MIME-Version 1.0
Content-Type text/plain; charset=us-ascii
Content-Disposition inline
Organization Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
User-Agent Mutt/1.7.1 (2016-10-04)
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 20
X-Original-Cc Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>, Bin Gao <bin.gao@intel.com>, Andy Shevchenko <andy.shevchenko@gmail.com>, Alexandre Courbot <gnurou@gmail.com>, "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, sathyaosid@gmail.com
X-Original-Date Wed, 26 Apr 2017 17:50:12 +0300
X-Original-Message-ID <20170426145012.GC7152@lahna.fi.intel.com>
X-Original-References <CAHp75VefVpwf-Ooom9Am3Gfmc8zR31fqWxTzYXest_+YTOk2yg@mail.gmail.com> <3257d22879148692da6887f89843389bd37ee877.1493060870.git.sathyanarayanan.kuppuswamy@linux.intel.com> <CACRpkda-GxRLJ=RHhDLRiu_ub=mpibQ7UPXg0=p-7jwJKpK5kg@mail.gmail.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1631501

Show key headers only | View raw


On Wed, Apr 26, 2017 at 04:26:17PM +0200, Linus Walleij wrote:
> On Mon, Apr 24, 2017 at 9:15 PM,
> <sathyanarayanan.kuppuswamy@linux.intel.com> wrote:
> 
> > From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
> >
> > According to Whiskey Cove PMIC spec, bit 7 of GPIOIRQ0_REG belongs to
> > battery IO. So we should skip this bit when checking for GPIO IRQ pending
> > status. Otherwise, wcove_gpio_irq_handler() might go into the infinite
> > loop until IRQ "pending" status becomes 0. This patch fixes this issue.
> >
> > Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
> 
> Looks fine to me, tentatively applied.
> 
> Bin, Mika, Andy, OK?

Looks fine to me as well :)

Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH v2 1/1] gpio: gpio-wcove: fix GPIO IRQ status mask Linus Walleij <linus.walleij@linaro.org> - 2017-04-26 16:30 +0200
  Re: [PATCH v2 1/1] gpio: gpio-wcove: fix GPIO IRQ status mask Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-04-26 17:00 +0200
  Re: [PATCH v2 1/1] gpio: gpio-wcove: fix GPIO IRQ status mask Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-04-26 17:00 +0200
  RE: [PATCH v2 1/1] gpio: gpio-wcove: fix GPIO IRQ status mask "Gao, Bin" <bin.gao@intel.com> - 2017-04-26 18:50 +0200

csiph-web