Re: [PATCH V4 1/9] PM / OPP: Allow OPP table to be used for power-domains

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH V4 1/9] PM / OPP: Allow OPP table to be used for power-domains
Date	2017-04-26 16:00 +0200
Message-ID	<tAvE5-2Zp-3@gated-at.bofh.it> (permalink)
References	(3 earlier) <tvFE5-6Oa-7@gated-at.bofh.it> <tvNii-3GT-17@gated-at.bofh.it> <tx7oC-5as-3@gated-at.bofh.it> <txDRw-8e8-23@gated-at.bofh.it> <tAmU9-5O3-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, Apr 26, 2017 at 10:02:39AM +0530, Rajendra Nayak wrote:
> > On 17/04/17 06:27, Viresh Kumar wrote:

> >>> If we are looking this power-domains with performance as just some
> >>> *advanced regulators*, I don't like the complexity added.

> + Mark

> I don;t see any public discussions on why we ruled out using regulators to
> support this but maybe there were some offline discussions on this.

> Mark, this is a long thread, so just summarizing here to give you the context.

> At qualcomm, we have an external M3 core (running its own firmware) which controls
> a few voltage rails (including AVS on those). The devices vote for the voltage levels
> (or performance levels) they need by passing an integer value to the M3 (not actual
> voltage values). Since that didn't fit well with the existing regulator apis it was

As I'm getting fed up of saying: if the values you are setting are not
voltages and do not behave like voltages then the hardware should not be
represented as a voltage regulator since if they are represented as
voltage regulators things will expect to be able to control them as
voltage regulators.  This hardware is quite clearly providing OPPs
directly, I would expect this to be handled in the OPP code somehow.

Thread

Re: [PATCH V4 1/9] PM / OPP: Allow OPP table to be used for  power-domains Rajendra Nayak <rnayak@codeaurora.org> - 2017-04-26 06:40 +0200
  Re: [PATCH V4 1/9] PM / OPP: Allow OPP table to be used for  power-domains Mark Brown <broonie@kernel.org> - 2017-04-26 16:00 +0200
    Re: [PATCH V4 1/9] PM / OPP: Allow OPP table to be used for  power-domains Sudeep Holla <sudeep.holla@arm.com> - 2017-04-27 11:50 +0200
      Re: [PATCH V4 1/9] PM / OPP: Allow OPP table to be used for  power-domains Rajendra Nayak <rnayak@codeaurora.org> - 2017-04-27 13:00 +0200
        Re: [PATCH V4 1/9] PM / OPP: Allow OPP table to be used for  power-domains Viresh Kumar <viresh.kumar@linaro.org> - 2017-04-28 07:10 +0200
          Re: [PATCH V4 1/9] PM / OPP: Allow OPP table to be used for  power-domains Sudeep Holla <sudeep.holla@arm.com> - 2017-04-28 11:50 +0200
            Re: [PATCH V4 1/9] PM / OPP: Allow OPP table to be used for  power-domains Viresh Kumar <viresh.kumar@linaro.org> - 2017-04-28 13:20 +0200
      Re: [PATCH V4 1/9] PM / OPP: Allow OPP table to be used for  power-domains Mark Brown <broonie@kernel.org> - 2017-04-30 14:50 +0200
        Re: [PATCH V4 1/9] PM / OPP: Allow OPP table to be used for  power-domains Sudeep Holla <sudeep.holla@arm.com> - 2017-05-03 13:30 +0200

csiph-web