Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1631398

Re: [PATCH] uapi: remove false assertion that statx_timestamp.tv_nsec can be negative

From David Howells <dhowells@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH] uapi: remove false assertion that statx_timestamp.tv_nsec can be negative
Date 2017-04-26 13:00 +0200
Message-ID <tAsPV-197-39@gated-at.bofh.it> (permalink)
References <tz8Tg-6PP-11@gated-at.bofh.it>
Organization Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903

Show all headers | View raw


Dmitry V. Levin <ldv@altlinux.org> wrote:

> remove false assertion

It's not a false assertion.  I defined the statx interface that way.

> The best fix for this source of confusion is to change the type
> of struct statx_timestamp.tv_nsec from __s32 to __u32 .

Okay, if we're going to do the comment change, we should effect the type
change also.  Do you want to update your patch?

David

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

Re: [PATCH] uapi: remove false assertion that statx_timestamp.tv_nsec can be negative David Howells <dhowells@redhat.com> - 2017-04-26 13:00 +0200
  [PATCH v2] uapi: change the type of struct statx_timestamp.tv_nsec  to unsigned "Dmitry V. Levin" <ldv@altlinux.org> - 2017-04-26 13:30 +0200

csiph-web