Re: [PATCH] memmap: Parse "Reserved" together with "reserved"

From	Simon Horman <horms@verge.net.au>
Newsgroups	linux.kernel
Subject	Re: [PATCH] memmap: Parse "Reserved" together with "reserved"
Date	2017-04-26 13:00 +0200
Message-ID	<tAsPV-197-33@gated-at.bofh.it> (permalink)
References	<tAoCC-6Wg-25@gated-at.bofh.it> <tAoCC-6Wg-23@gated-at.bofh.it> <tApyF-7vI-15@gated-at.bofh.it> <tApIl-7Ah-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Apr 26, 2017 at 03:31:48PM +0800, Dave Young wrote:
> On 04/26/17 at 03:28pm, Dave Young wrote:
> > On 04/26/17 at 08:22am, Ingo Molnar wrote:
> > > 
> > > * Yinghai Lu <yinghai@kernel.org> wrote:
> > > 
> > > > For x86 with recent kernel after
> > > >  commit 640e1b38b0 ("x86/boot/e820: Basic cleanup of e820.c")
> > > > change "reserved" to "Reserved" in /sys firmware memmap and /proc/iomem.
> > > > 
> > > > So here, we add handling for that too.
> > > > 
> > > > Signed-off-by: Yinghai Lu <yinghai@kernel.org>
> > > > 
> > > > ---
> > > >  kexec/arch/i386/crashdump-x86.c |    2 ++
> > > >  kexec/arch/ia64/kexec-ia64.c    |    2 ++
> > > >  kexec/arch/mips/kexec-mips.c    |    2 ++
> > > >  kexec/firmware_memmap.c         |    2 ++
> > > >  4 files changed, 8 insertions(+)
> > > 
> > > I'd rather fix the bug I introduced and undo the reserved->Reserved string change 
> > 
> > This patch parses both 'reserved' and 'Reserved' it should be fine, but
> > reverting the change in kernel sounds better..
> 
> Hmm, after press sending I noticed old kexec-tools with new kernel, it
> is still a problem, so we'd better to revert the kernel changes.

FWIW, if the kernel change hasn't hit a release then reverting (the
reserved->Reserved portion of) it would be my preference.

> > > in e820.c: I didn't realize that it's exposed in sysfs and had quasi-ABI 
> > > consequences for kexec.
> > > 
> > > Agreed?
> > > 
> > > Thanks,
> > > 
> > > 	Ingo
> > > 
> > > _______________________________________________
> > > kexec mailing list
> > > kexec@lists.infradead.org
> > > http://lists.infradead.org/mailman/listinfo/kexec
> > 
> > Thanks
> > Dave
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] memmap: Parse "Reserved" together with "reserved" Ingo Molnar <mingo@kernel.org> - 2017-04-26 08:30 +0200
  Re: [PATCH] memmap: Parse "Reserved" together with "reserved" Dave Young <dyoung@redhat.com> - 2017-04-26 09:30 +0200
    Re: [PATCH] memmap: Parse "Reserved" together with "reserved" Dave Young <dyoung@redhat.com> - 2017-04-26 09:40 +0200
      Re: [PATCH] memmap: Parse "Reserved" together with "reserved" Simon Horman <horms@verge.net.au> - 2017-04-26 13:00 +0200

csiph-web