Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1631374

[PATCH 0/2] Introduce crtc->mode_valid() callback

From Jose Abreu <Jose.Abreu@synopsys.com>
Newsgroups linux.kernel
Subject [PATCH 0/2] Introduce crtc->mode_valid() callback
Date 2017-04-26 12:50 +0200
Message-ID <tAsGe-15h-17@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


This patchset introduces a new callback for crtc, called mode_valid()
that is responsible to limit the number of probbed modes. Just like
connector->mode_valid(), this new callback is called at mode probbing
stage so that we can validate the mode.

This is specially useful because arcpgu crtc is responsible to set a
clock value in the commit() stage but unfortunatelly this clock does
not support all the needed ranges. This way we can restrict the number
of modes that are handed to userspace, so that we dont hand a mode
that will fail the commit() stage.

I guess this can also happen for other drivers so we introduce the
callback in the core.

The behaviour remains the same for crtcs that don't have the callback.
Also, for a given set of crtcs that can be bound to the connector, if
at least one can display the mode then the mode will be probbed.

For more info about why this is needed in arcpgu, please refer here [1].

[1] https://patchwork.kernel.org/patch/9694177/

Jose Abreu (2):
  drm: Introduce crtc->mode_valid() callback
  drm: arcpgu: Use crtc->mode_valid() callback

Cc: Carlos Palminha <palminha@synopsys.com>
Cc: Alexey Brodkin <abrodkin@synopsys.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Dave Airlie <airlied@linux.ie>

 drivers/gpu/drm/arc/arcpgu_crtc.c        | 14 ++++++++++
 drivers/gpu/drm/drm_probe_helper.c       | 44 ++++++++++++++++++++++++++++++++
 include/drm/drm_modeset_helper_vtables.h | 26 +++++++++++++++++++
 3 files changed, 84 insertions(+)

-- 
1.9.1

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[PATCH 0/2] Introduce crtc->mode_valid() callback Jose Abreu <Jose.Abreu@synopsys.com> - 2017-04-26 12:50 +0200
  [PATCH 2/2] drm: arcpgu: Use crtc->mode_valid() callback Jose Abreu <Jose.Abreu@synopsys.com> - 2017-04-26 13:00 +0200
  [PATCH 1/2] drm: Introduce crtc->mode_valid() callback Jose Abreu <Jose.Abreu@synopsys.com> - 2017-04-26 13:00 +0200
    Re: [PATCH 1/2] drm: Introduce crtc->mode_valid() callback Andrzej Hajda <a.hajda@samsung.com> - 2017-04-27 12:10 +0200
      Re: [PATCH 1/2] drm: Introduce crtc->mode_valid() callback Jose Abreu <Jose.Abreu@synopsys.com> - 2017-04-27 14:40 +0200
    Re: [PATCH 1/2] drm: Introduce crtc->mode_valid() callback Ville Syrjälä <ville.syrjala@linux.intel.com> - 2017-04-28 13:50 +0200
      Re: [PATCH 1/2] drm: Introduce crtc->mode_valid() callback Jose Abreu <Jose.Abreu@synopsys.com> - 2017-04-28 14:40 +0200
        Re: [PATCH 1/2] drm: Introduce crtc->mode_valid() callback Ville Syrjälä <ville.syrjala@linux.intel.com> - 2017-04-28 15:00 +0200
    Re: [PATCH 1/2] drm: Introduce crtc->mode_valid() callback Daniel Vetter <daniel@ffwll.ch> - 2017-05-02 10:50 +0200
      Re: [PATCH 1/2] drm: Introduce crtc->mode_valid() callback Jose Abreu <Jose.Abreu@synopsys.com> - 2017-05-02 11:30 +0200
        Re: [PATCH 1/2] drm: Introduce crtc->mode_valid() callback Daniel Vetter <daniel@ffwll.ch> - 2017-05-03 08:20 +0200
          Re: [PATCH 1/2] drm: Introduce crtc->mode_valid() callback Jose Abreu <Jose.Abreu@synopsys.com> - 2017-05-03 16:20 +0200
            Re: [PATCH 1/2] drm: Introduce crtc->mode_valid() callback Daniel Vetter <daniel@ffwll.ch> - 2017-05-03 17:10 +0200
              Re: [PATCH 1/2] drm: Introduce crtc->mode_valid() callback Ville Syrjälä <ville.syrjala@linux.intel.com> - 2017-05-03 17:30 +0200
                Re: [PATCH 1/2] drm: Introduce crtc->mode_valid() callback Daniel Vetter <daniel@ffwll.ch> - 2017-05-04 14:50 +0200
                Re: [PATCH 1/2] drm: Introduce crtc->mode_valid() callback Ville Syrjälä <ville.syrjala@linux.intel.com> - 2017-05-04 15:10 +0200
              Re: [PATCH 1/2] drm: Introduce crtc->mode_valid() callback Jose Abreu <Jose.Abreu@synopsys.com> - 2017-05-04 12:30 +0200
                Re: [PATCH 1/2] drm: Introduce crtc->mode_valid() callback Jose Abreu <Jose.Abreu@synopsys.com> - 2017-05-04 14:00 +0200
                Re: [PATCH 1/2] drm: Introduce crtc->mode_valid() callback Daniel Vetter <daniel@ffwll.ch> - 2017-05-04 14:50 +0200
        Re: [PATCH 1/2] drm: Introduce crtc->mode_valid() callback Daniel Vetter <daniel@ffwll.ch> - 2017-05-03 08:30 +0200

csiph-web