[PATCH] drbd:fix null pointer deref in _drbd_md_sync_page_io

From	Heloise <os@iscas.ac.cn>
Newsgroups	linux.kernel
Subject	[PATCH] drbd:fix null pointer deref in _drbd_md_sync_page_io
Date	2017-04-26 12:10 +0200
Message-ID	<tAs3v-Rc-15@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

The return value of bio_alloc_drbd can be NULL and is used without
validation, which may cause null-pointer dereference, fix it.

Signed-off-by: Heloise <os@iscas.ac.cn>
---
 drivers/block/drbd/drbd_actlog.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/block/drbd/drbd_actlog.c b/drivers/block/drbd/drbd_actlog.c
index 8d7bcfa..d6bb30e 100644
--- a/drivers/block/drbd/drbd_actlog.c
+++ b/drivers/block/drbd/drbd_actlog.c
@@ -151,6 +151,10 @@ static int _drbd_md_sync_page_io(struct drbd_device *device,
 	op_flags |= REQ_SYNC;
 
 	bio = bio_alloc_drbd(GFP_NOIO);
+	if (!bio) {
+		err = -ENOMEM;
+		return err;
+	}
 	bio->bi_bdev = bdev->md_bdev;
 	bio->bi_iter.bi_sector = sector;
 	err = -EIO;
-- 
2.1.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] drbd:fix null pointer deref in _drbd_md_sync_page_io  Heloise <os@iscas.ac.cn> - 2017-04-26 12:10 +0200
  Re: [PATCH] drbd:fix null pointer deref in _drbd_md_sync_page_io Lars Ellenberg <lars.ellenberg@linbit.com> - 2017-04-26 15:30 +0200

csiph-web