[PATCH] omapfb: Use devm_kcalloc() in vrfb_probe()

From	SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups	linux.kernel
Subject	[PATCH] omapfb: Use devm_kcalloc() in vrfb_probe()
Date	2017-04-26 11:40 +0200
Message-ID	<tArAu-oA-9@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 26 Apr 2017 11:08:30 +0200

* A multiplication for the size determination of a memory allocation
  indicated that an array data structure should be processed.
  Thus use the corresponding function "devm_kcalloc".

* Replace the specification of a data structure by a pointer dereference
  to make the corresponding size determination a bit safer according to
  the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/video/fbdev/omap2/omapfb/vrfb.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/video/fbdev/omap2/omapfb/vrfb.c b/drivers/video/fbdev/omap2/omapfb/vrfb.c
index f346b02eee1d..54b51a7a290a 100644
--- a/drivers/video/fbdev/omap2/omapfb/vrfb.c
+++ b/drivers/video/fbdev/omap2/omapfb/vrfb.c
@@ -358,11 +358,7 @@ static int __init vrfb_probe(struct platform_device *pdev)
 		return PTR_ERR(vrfb_base);

 	num_ctxs = pdev->num_resources - 1;
-
-	ctxs = devm_kzalloc(&pdev->dev,
-			sizeof(struct vrfb_ctx) * num_ctxs,
-			GFP_KERNEL);
-
+	ctxs = devm_kcalloc(&pdev->dev, num_ctxs, sizeof(*ctxs), GFP_KERNEL);
 	if (!ctxs)
 		return -ENOMEM;

-- 
2.12.2

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] omapfb: Use devm_kcalloc() in vrfb_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-26 11:40 +0200
  Re: [PATCH] omapfb: Use devm_kcalloc() in vrfb_probe() Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-05-11 16:30 +0200
    Re: [PATCH] omapfb: Use devm_kcalloc() in vrfb_probe() Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-05-11 17:30 +0200

csiph-web