Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1631098

[RFC PATCH] ACPICA: Tables: Fix regression introduced by a too early mechanism enabling

Show all headers | View raw

In the Linux kernel side, acpi_get_table() hasn't been fully balanced by
acpi_put_table() invocations. So it is not a good timing to report errors.
The strict balanced validation count check should only be enabled after
confirming that all kernel side invocations are safe.

Thus this patch removes the fatal error but leaves the error report to
indicate the leak so that developers can notice the required engineering
change. Reported by Dan Williams, fixed by Lv Zheng.

Reported-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Lv Zheng <lv.zheng@intel.com>
---
 drivers/acpi/acpica/tbutils.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/acpi/acpica/tbutils.c b/drivers/acpi/acpica/tbutils.c
index 5a968a7..9e7d95cf 100644
--- a/drivers/acpi/acpica/tbutils.c
+++ b/drivers/acpi/acpica/tbutils.c
@@ -422,7 +422,6 @@ acpi_tb_get_table(struct acpi_table_desc *table_desc,
 			    "Table %p, Validation count is zero after increment\n",
 			    table_desc));
 		table_desc->validation_count--;
-		return_ACPI_STATUS(AE_LIMIT);
 	}
 
 	*out_table = table_desc->pointer;
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH] ACPICA: Tables: Fix regression introduced by a too early mechanism enabling Lv Zheng <lv.zheng@intel.com> - 2017-04-26 04:00 +0200
  Re: [RFC PATCH] ACPICA: Tables: Fix regression introduced by a too  early mechanism enabling Dan Williams <dan.j.williams@intel.com> - 2017-04-26 07:10 +0200
    RE: [RFC PATCH] ACPICA: Tables: Fix regression introduced by a too  early mechanism enabling "Zheng, Lv" <lv.zheng@intel.com> - 2017-04-26 07:20 +0200
      Re: [RFC PATCH] ACPICA: Tables: Fix regression introduced by a too  early mechanism enabling Dan Williams <dan.j.williams@intel.com> - 2017-04-26 16:20 +0200
        Re: [RFC PATCH] ACPICA: Tables: Fix regression introduced by a too  early mechanism enabling Dan Williams <dan.j.williams@intel.com> - 2017-04-26 17:40 +0200

csiph-web