Re: [PATCH] FS-Cache: print hexadecimal value for special cookies type

From	Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] FS-Cache: print hexadecimal value for special cookies type
Date	2017-04-26 00:10 +0200
Message-ID	<tAgOK-23i-15@gated-at.bofh.it> (permalink)
References	<ty4yl-7Xj-5@gated-at.bofh.it> <tyMJ3-1nm-1@gated-at.bofh.it> <tyPQB-3tW-3@gated-at.bofh.it> <tzU1P-3Vb-11@gated-at.bofh.it> <tAglJ-1EE-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Apr 26, 2017 at 12:37 AM, Jérémy Lefaure
<jeremy.lefaure@lse.epita.fr> wrote:
> On Tue, 25 Apr 2017 00:47:41 +0300
> Andy Shevchenko <andy.shevchenko@gmail.com> wrote:

> Ok I get it. But changing the format can break the userland tool
> anyway, can't it ? For example if a userland tool expects the value 75,
> it won't read it properpy in BCD.

Maybe.

>> So, if it's okay in this, perhaps paragraph explaining side effects in
>> commit message would be good to have/
>>
> Maybe the best fix would be to increase the size of the _type buffer to
> 4 so the unsigned byte can fit in it. And change the documentation to
> decimal value. What do you think about this solution ?

Yes, it would work.

-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] FS-Cache: print hexadecimal value for special cookies type Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-04-24 23:50 +0200
  Re: [PATCH] FS-Cache: print hexadecimal value for special cookies  type Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> - 2017-04-25 23:40 +0200
    Re: [PATCH] FS-Cache: print hexadecimal value for special cookies type Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-04-26 00:10 +0200

csiph-web