Re: [PATCH v1] net: phy: fix auto-negotiation stall due to unavailable interrupt

From	Alexandre Belloni <alexandre.belloni@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v1] net: phy: fix auto-negotiation stall due to unavailable interrupt
Date	2017-04-25 22:20 +0200
Message-ID	<tAf6i-Vi-13@gated-at.bofh.it> (permalink)
References	<tyi8h-8cx-1@gated-at.bofh.it> <tyi8i-8cx-33@gated-at.bofh.it> <tA9Ng-5S4-13@gated-at.bofh.it> <tAazF-6sV-51@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

On 25/04/2017 at 18:25:30 +0300, Alexander Kochetkov wrote:
> Hello David!
> 
> > 25 апр. 2017 г., в 17:36, David Miller <davem@davemloft.net> написал(а):
> > 
> > So... what are we doing here?
> > 
> > My understanding is that this should fix the same problem that commit
> > 99f81afc139c6edd14d77a91ee91685a414a1c66 ("phy: micrel: Disable auto
> > negotiation on startup") fixed and that this micrel commit should thus
> > be reverted to improve MAC startup times which regressed.
> > 
> > Florian, any guidance?
> 
> Yes, this should be done.
> 
> I aksed Alexandre to check if 99f81afc139c6edd14d77a91ee91685a414a1c66 ("phy: micrel: Disable auto
> negotiation on startup») can be reverted, and he answered what it may do that
> sometime this/next week.
> 

Yes, it can be safely reverted after Alexander's patch. I had to test on
v4.7 because we are not using interrupts on those boards since v4.8
(another issue to be fixed).

As Florian pointed out, at the time I sent my patch, I didn't have time
to investigate whether this was affecting other phys, see
https://lkml.org/lkml/2016/2/26/766

I can send the revert or you can do it.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Thread

Re: [PATCH v1] net: phy: fix auto-negotiation stall due to  unavailable interrupt David Miller <davem@davemloft.net> - 2017-04-25 16:40 +0200
  Re: [PATCH v1] net: phy: fix auto-negotiation stall due to unavailable interrupt Alexander Kochetkov <al.kochet@gmail.com> - 2017-04-25 17:30 +0200
    Re: [PATCH v1] net: phy: fix auto-negotiation stall due to  unavailable interrupt Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-04-25 22:20 +0200
      Re: [PATCH v1] net: phy: fix auto-negotiation stall due to  unavailable interrupt David Miller <davem@davemloft.net> - 2017-04-25 22:30 +0200
        Re: [PATCH v1] net: phy: fix auto-negotiation stall due to  unavailable interrupt Florian Fainelli <f.fainelli@gmail.com> - 2017-04-25 23:10 +0200
      Re: [PATCH v1] net: phy: fix auto-negotiation stall due to  unavailable interrupt Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-04-26 12:30 +0200

csiph-web