Re: [PATCH] staging: ks7010: fix few checkpatch warnings in ks_wlan_net.c

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging: ks7010: fix few checkpatch warnings in ks_wlan_net.c
Date	2017-04-25 21:20 +0200
Message-ID	<tAead-kQ-1@gated-at.bofh.it> (permalink)
References	<tAead-kQ-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Apr 25, 2017 at 09:02:48PM +0200, Ilia Sergachev wrote:
> Fixes few warnings and checks in drivers/staging/ks7010/ks_wlan_net.c

What type of warnings?  What checks?  It builds just fine for me here.

You need to be very specific.

And only do one type of thing per patch, a big "fixes all types of
warnings" is not ok in a single patch.

> 
> Signed-off-by: Ilia Sergachev <BM-2cVwRgNYPK72fLRfbWfkkmYLu7qHhYpwtr@bitmessage.ch>
> Cc: devel@driverdev.osuosl.org,linux-kernel@vger.kernel.org

That last line doesn't make much sense, does it?

thanks,

greg k-h

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] staging: ks7010: fix few checkpatch warnings in  ks_wlan_net.c Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-04-25 21:20 +0200

csiph-web