Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1630877

Re: [PATCH] drivers: dma-mapping: Do not leave an invalid area->pages pointer in dma_common_contiguous_remap()

Show all headers | View raw

On Tue, Apr 25, 2017 at 07:22:23PM +0100, Catalin Marinas wrote:
> The dma_common_pages_remap() function allocates a vm_struct object and
> initialises the pages pointer to value passed as argument. However, when
> this function is called dma_common_contiguous_remap(), the pages array
> is only temporarily allocated, being freed shortly after
> dma_common_contiguous_remap() returns. Architecture code checking the
> validity of an area->pages pointer would incorrectly dereference already
> freed pointers. This has been exposed by the arm64 commit 44176bb38fa4
> ("arm64: Add support for DMA_ATTR_FORCE_CONTIGUOUS to IOMMU").
> 
> Fixes: 513510ddba96 ("common: dma-mapping: introduce common remapping functions")
> Cc: Laura Abbott <labbott@redhat.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Reported-by: Andrzej Hajda <a.hajda@samsung.com>
> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>

Small correction on the subject, the prefix should be something like:

drivers: dma-mapping:

It's not an arm64 patch.

-- 
Catalin

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] arm64: Do not leave an invalid area->pages pointer in dma_common_contiguous_remap() Catalin Marinas <catalin.marinas@arm.com> - 2017-04-25 20:30 +0200
  Re: [PATCH] drivers: dma-mapping: Do not leave an invalid  area->pages pointer in dma_common_contiguous_remap() Catalin Marinas <catalin.marinas@arm.com> - 2017-04-25 20:30 +0200
    Re: [PATCH] drivers: dma-mapping: Do not leave an invalid  area->pages pointer in dma_common_contiguous_remap() Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-04-28 18:20 +0200
  Re: [PATCH] arm64: Do not leave an invalid area->pages pointer in  dma_common_contiguous_remap() Laura Abbott <labbott@redhat.com> - 2017-04-25 21:40 +0200
  Re: [PATCH] arm64: Do not leave an invalid area->pages pointer in  dma_common_contiguous_remap() Robin Murphy <robin.murphy@arm.com> - 2017-05-03 14:20 +0200
    Re: [PATCH] arm64: Do not leave an invalid area->pages pointer in  dma_common_contiguous_remap() Catalin Marinas <catalin.marinas@arm.com> - 2017-05-03 16:20 +0200

csiph-web