Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1630834

Re: [PATCH] ipv6: ensure message length for raw socket is at least sizeof(ipv6hdr)

From David Miller <davem@davemloft.net>
Newsgroups linux.kernel
Subject Re: [PATCH] ipv6: ensure message length for raw socket is at least sizeof(ipv6hdr)
Date 2017-04-25 20:00 +0200
Message-ID <tAcUO-7ME-5@gated-at.bofh.it> (permalink)
References <tA8xQ-5bb-31@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Alexander Potapenko <glider@google.com>
Date: Tue, 25 Apr 2017 15:18:27 +0200

> rawv6_send_hdrinc() expects that the buffer copied from the userspace
> contains the IPv6 header, so if too few bytes are copied parts of the
> header may remain uninitialized.
> 
> This bug has been detected with KMSAN.
> 
> Signed-off-by: Alexander Potapenko <glider@google.com>

Hmmm, ipv4 seems to lack this check as well.

I think we need to be careful here and fully understand why KMSAN doesn't
seem to be triggering in the ipv4 case but for ipv6 it is before I apply
this.

Thanks.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] ipv6: ensure message length for raw socket is at least sizeof(ipv6hdr) Alexander Potapenko <glider@google.com> - 2017-04-25 15:20 +0200
  Re: [PATCH] ipv6: ensure message length for raw socket is at least  sizeof(ipv6hdr) David Miller <davem@davemloft.net> - 2017-04-25 20:00 +0200
    Re: [PATCH] ipv6: ensure message length for raw socket is at least sizeof(ipv6hdr) Eric Dumazet <edumazet@google.com> - 2017-04-25 20:20 +0200
    Re: [PATCH] ipv6: ensure message length for raw socket is at least sizeof(ipv6hdr) Alexander Potapenko <glider@google.com> - 2017-04-26 11:00 +0200
      Re: [PATCH] ipv6: ensure message length for raw socket is at least sizeof(ipv6hdr) Alexander Potapenko <glider@google.com> - 2017-04-26 15:10 +0200
        Re: [PATCH] ipv6: ensure message length for raw socket is at least sizeof(ipv6hdr) Alexander Potapenko <glider@google.com> - 2017-04-28 16:40 +0200
          Re: [PATCH] ipv6: ensure message length for raw socket is at least  sizeof(ipv6hdr) David Miller <davem@davemloft.net> - 2017-04-28 16:40 +0200

csiph-web