Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1630719
| From | Peter Zijlstra <peterz@infradead.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 4/4] sched/topology: the group balance cpu must be a cpu where the group is installed |
| Date | 2017-04-25 18:00 +0200 |
| Message-ID | <tAb2F-6Ff-19@gated-at.bofh.it> (permalink) |
| References | (5 earlier) <tA9Nf-5S4-1@gated-at.bofh.it> <tAazE-6sV-15@gated-at.bofh.it> <tAazE-6sV-17@gated-at.bofh.it> <tAazE-6sV-13@gated-at.bofh.it> <tAaT0-6BR-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, Apr 25, 2017 at 05:39:37PM +0200, Peter Zijlstra wrote:
> On Tue, Apr 25, 2017 at 05:27:03PM +0200, Peter Zijlstra wrote:
> > Ah! the asymmetric setup, where @sibling is entirely uninitialized for
> > the top domain.
Like so then...
--- a/kernel/sched/topology.c
+++ b/kernel/sched/topology.c
@@ -509,6 +509,11 @@ static void build_group_mask(struct sche
for_each_cpu(i, sg_span) {
sibling = *per_cpu_ptr(sdd->sd, i);
+ /*
+ * Can happen in the asymmetric case, where these siblings are
+ * unused. The mask will not be empty because those CPUs that
+ * do have the top domain _should_ span the domain.
+ */
if (!sibling->child)
continue;
@@ -518,6 +523,9 @@ static void build_group_mask(struct sche
cpumask_set_cpu(i, sched_group_mask(sg));
}
+
+ /* We must not have empty masks here */
+ WARN_ON_ONCE(cpumask_empty(sched_group_mask(sg)));
}
/*
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH 4/4] sched/topology: the group balance cpu must be a cpu where the group is installed Peter Zijlstra <peterz@infradead.org> - 2017-04-25 14:20 +0200
Re: [PATCH 4/4] sched/topology: the group balance cpu must be a cpu where the group is installed Lauro Venancio <lvenanci@redhat.com> - 2017-04-25 16:40 +0200
Re: [PATCH 4/4] sched/topology: the group balance cpu must be a cpu where the group is installed Peter Zijlstra <peterz@infradead.org> - 2017-04-25 17:30 +0200
Re: [PATCH 4/4] sched/topology: the group balance cpu must be a cpu where the group is installed Peter Zijlstra <peterz@infradead.org> - 2017-04-25 17:50 +0200
Re: [PATCH 4/4] sched/topology: the group balance cpu must be a cpu where the group is installed Peter Zijlstra <peterz@infradead.org> - 2017-04-25 18:00 +0200
Re: [PATCH 4/4] sched/topology: the group balance cpu must be a cpu where the group is installed Lauro Venancio <lvenanci@redhat.com> - 2017-04-25 18:00 +0200
Re: [PATCH 4/4] sched/topology: the group balance cpu must be a cpu where the group is installed Peter Zijlstra <peterz@infradead.org> - 2017-04-25 18:30 +0200
Re: [PATCH 4/4] sched/topology: the group balance cpu must be a cpu where the group is installed Peter Zijlstra <peterz@infradead.org> - 2017-04-25 17:30 +0200
Re: [PATCH 4/4] sched/topology: the group balance cpu must be a cpu where the group is installed Peter Zijlstra <peterz@infradead.org> - 2017-04-25 17:30 +0200
csiph-web