Re: [PATCH 2/2] ARM: dts: Add the ethernet and ethernet PHY to the cygnus core DT.

From	Jon Mason <jon.mason@broadcom.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] ARM: dts: Add the ethernet and ethernet PHY to the cygnus core DT.
Date	2017-04-25 17:50 +0200
Message-ID	<tAaT0-6BR-19@gated-at.bofh.it> (permalink)
References	<tzUbw-3Yp-5@gated-at.bofh.it> <tzUbw-3Yp-7@gated-at.bofh.it> <tA5gB-2XU-13@gated-at.bofh.it> <tAaq0-6oY-93@gated-at.bofh.it> <tAazG-6sV-67@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Apr 25, 2017 at 11:23 AM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Hello!
>
> On 04/25/2017 06:15 PM, Jon Mason wrote:
>
>>>> Cygnus has a single amac controller connected to the B53 switch with 2
>>>> PHYs.  On the BCM911360_EP platform, those two PHYs are connected to
>>>> the external ethernet jacks.
>
>
> [...]
>
>>>> Signed-off-by: Eric Anholt <eric@anholt.net>
>>>> ---
>>>>  arch/arm/boot/dts/bcm-cygnus.dtsi      | 60
>>>> ++++++++++++++++++++++++++++++++++
>>>>  arch/arm/boot/dts/bcm911360_entphn.dts |  8 +++++
>>>>  2 files changed, 68 insertions(+)
>>>>
>>>> diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi
>>>> b/arch/arm/boot/dts/bcm-cygnus.dtsi
>>>> index 009f1346b817..318899df9972 100644
>>>> --- a/arch/arm/boot/dts/bcm-cygnus.dtsi
>>>> +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi
>
> [...]
>>>>
>>>> @@ -295,6 +345,16 @@
>>>>                         status = "disabled";
>>>>                 };
>>>>
>>>> +               eth0: enet@18042000 {
>>>> +                       compatible = "brcm,amac";
>>>> +                       reg = <0x18042000 0x1000>,
>>>> +                             <0x18110000 0x1000>;
>>>> +                       reg-names = "amac_base", "idm_base";
>>>
>>>
>>>
>>>    I don't think "_base" suffixes are necessary here.
>>
>>
>> 100% necessary, per the driver.  See
>> drivers/net/ethernet/broadcom/bgmac-platform.c
>
>
>    I'd recommend to fix the driver/bindings then...

They're already in use in other device trees.  So, we'd need to
support backward compatibility on them, thus removing any real benefit
to changing them.


>
> MBR, Sergei
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] ARM: dts: Add the ethernet and ethernet PHY to the cygnus core DT. Eric Anholt <eric@anholt.net> - 2017-04-25 00:00 +0200
  Re: [PATCH 2/2] ARM: dts: Add the ethernet and ethernet PHY to the  cygnus core DT. Andrew Lunn <andrew@lunn.ch> - 2017-04-25 00:10 +0200
    Re: [PATCH 2/2] ARM: dts: Add the ethernet and ethernet PHY to the cygnus core DT. Eric Anholt <eric@anholt.net> - 2017-04-25 02:10 +0200
  Re: [PATCH 2/2] ARM: dts: Add the ethernet and ethernet PHY to the  cygnus core DT. Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2017-04-25 11:50 +0200
  Re: [PATCH 2/2] ARM: dts: Add the ethernet and ethernet PHY to the  cygnus core DT. Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2017-04-25 11:50 +0200
    Re: [PATCH 2/2] ARM: dts: Add the ethernet and ethernet PHY to the  cygnus core DT. Jon Mason <jon.mason@broadcom.com> - 2017-04-25 17:20 +0200
      Re: [PATCH 2/2] ARM: dts: Add the ethernet and ethernet PHY to the  cygnus core DT. Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2017-04-25 17:30 +0200
        Re: [PATCH 2/2] ARM: dts: Add the ethernet and ethernet PHY to the  cygnus core DT. Jon Mason <jon.mason@broadcom.com> - 2017-04-25 17:50 +0200

csiph-web