Re: [PATCH v2 1/3] mm: Silence vmap() allocation failures based on caller gfp_flags

From	Michal Hocko <mhocko@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/3] mm: Silence vmap() allocation failures based on caller gfp_flags
Date	2017-04-27 20:30 +0200
Message-ID	<tAWkW-4nM-5@gated-at.bofh.it> (permalink)
References	<tAVyy-3KJ-21@gated-at.bofh.it> <tAVId-3OA-1@gated-at.bofh.it> <tAVRU-3TB-17@gated-at.bofh.it> <tAW1z-4ez-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu 27-04-17 11:03:31, Florian Fainelli wrote:
> On 04/27/2017 10:56 AM, Michal Hocko wrote:
> > On Thu 27-04-17 10:38:58, Florian Fainelli wrote:
> >> If the caller has set __GFP_NOWARN don't print the following message:
> >> vmap allocation for size 15736832 failed: use vmalloc=<size> to increase
> >> size.
> >>
> >> This can happen with the ARM/Linux or ARM64/Linux module loader built
> >> with CONFIG_ARM{,64}_MODULE_PLTS=y which does a first attempt at loading
> >> a large module from module space, then falls back to vmalloc space.
> >>
> >> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> > 
> > Acked-by: Michal Hocko <mhocko@suse.com>
> > 
> > just a nit
> > 
> >> ---
> >>  mm/vmalloc.c | 4 ++++
> >>  1 file changed, 4 insertions(+)
> >>
> >> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> >> index 0b057628a7ba..d8a851634674 100644
> >> --- a/mm/vmalloc.c
> >> +++ b/mm/vmalloc.c
> >> @@ -521,9 +521,13 @@ static struct vmap_area *alloc_vmap_area(unsigned long size,
> >>  		}
> >>  	}
> >>  
> >> +	if (gfp_mask & __GFP_NOWARN)
> >> +		goto out;
> >> +
> >>  	if (printk_ratelimit())
> > 
> > 	if (!(gfp_mask & __GFP_NOWARN) && printk_ratelimit())
> >>  		pr_warn("vmap allocation for size %lu failed: use vmalloc=<size> to increase size\n",
> >>  			size);
> > 
> > would be shorter and you wouldn't need the goto and a label.
> 
> Do you want me to resubmit with that change included?

Up to you. As I've said this is a nit at best.
-- 
Michal Hocko
SUSE Labs

Thread

[PATCH 0/3 v2] ARM/ARM64: silence large module first time allocation Florian Fainelli <f.fainelli@gmail.com> - 2017-04-27 19:40 +0200
  [PATCH v2 1/3] mm: Silence vmap() allocation failures based on caller gfp_flags Florian Fainelli <f.fainelli@gmail.com> - 2017-04-27 19:50 +0200
    Re: [PATCH v2 1/3] mm: Silence vmap() allocation failures based on  caller gfp_flags Michal Hocko <mhocko@kernel.org> - 2017-04-27 20:00 +0200
      Re: [PATCH v2 1/3] mm: Silence vmap() allocation failures based on  caller gfp_flags Florian Fainelli <f.fainelli@gmail.com> - 2017-04-27 20:10 +0200
        Re: [PATCH v2 1/3] mm: Silence vmap() allocation failures based on  caller gfp_flags Florian Fainelli <f.fainelli@gmail.com> - 2017-04-27 20:30 +0200
        Re: [PATCH v2 1/3] mm: Silence vmap() allocation failures based on  caller gfp_flags Michal Hocko <mhocko@kernel.org> - 2017-04-27 20:30 +0200
  [PATCH v2 3/3] arm64: Silence first allocation with CONFIG_ARM64_MODULE_PLTS=y Florian Fainelli <f.fainelli@gmail.com> - 2017-04-27 19:50 +0200
    Re: [PATCH v2 3/3] arm64: Silence first allocation with CONFIG_ARM64_MODULE_PLTS=y Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2017-04-27 20:10 +0200
      Re: [PATCH v2 3/3] arm64: Silence first allocation with  CONFIG_ARM64_MODULE_PLTS=y Florian Fainelli <f.fainelli@gmail.com> - 2017-04-27 20:20 +0200
        Re: [PATCH v2 3/3] arm64: Silence first allocation with CONFIG_ARM64_MODULE_PLTS=y Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2017-04-27 20:20 +0200
  [PATCH v2 2/3] ARM: Silence first allocation with CONFIG_ARM_MODULE_PLTS=y Florian Fainelli <f.fainelli@gmail.com> - 2017-04-27 19:50 +0200

csiph-web