Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1632270

Re: [PATCH] arm64: cpufeature: use static_branch_enable_cpuslocked()

From Mark Rutland <mark.rutland@arm.com>
Newsgroups linux.kernel
Subject Re: [PATCH] arm64: cpufeature: use static_branch_enable_cpuslocked()
Date 2017-04-27 19:20 +0200
Message-ID <tAVfb-3DH-3@gated-at.bofh.it> (permalink)
References (5 earlier) <tAOx3-7td-7@gated-at.bofh.it> <tAQSd-Bq-3@gated-at.bofh.it> <tATQ6-2Ak-19@gated-at.bofh.it> <tAUCu-3ai-21@gated-at.bofh.it> <tAV5v-3A6-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, Apr 27, 2017 at 06:03:35PM +0100, Suzuki K Poulose wrote:
> On 27/04/17 17:35, Suzuki K Poulose wrote:
> >@@ -1092,7 +1093,9 @@ void check_local_cpu_capabilities(void)
> >
> > static void __init setup_feature_capabilities(void)
> > {
> >-	update_cpu_capabilities(arm64_features, "detected feature:");
> >+	get_online_cpus();
> >+	update_cpu_capabilities(arm6_features, "detected feature:");
> 
> s/arm6_features/arm64_features
> 
> And we need the following hunk:
> 
> diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c
> index 62bdab4..19c359a 100644
> --- a/arch/arm64/kernel/cpufeature.c
> +++ b/arch/arm64/kernel/cpufeature.c
> @@ -1086,7 +1086,7 @@ void check_local_cpu_capabilities(void)
>          * advertised capabilities.
>          */
>         if (!sys_caps_initialised)
> -               update_cpu_errata_workarounds();
> +               update_secondary_cpu_errata_workarounds();
>         else
>                 verify_local_cpu_capabilities();
>  }
> 
> Sorry about that.

No worries; thanks for the fixups.

With those this is working for me, so I'll send this and Sebastian's
patch (with Ccs) as a new series.

> 
> Suzuki

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

Re: [patch V2 00/24] cpu/hotplug: Convert get_online_cpus() to a  percpu_rwsem Mark Rutland <mark.rutland@arm.com> - 2017-04-25 18:20 +0200
  Re: [patch V2 00/24] cpu/hotplug: Convert get_online_cpus() to a  percpu_rwsem Sebastian Siewior <bigeasy@linutronix.de> - 2017-04-25 19:30 +0200
    Re: [patch V2 00/24] cpu/hotplug: Convert get_online_cpus() to a  percpu_rwsem Mark Rutland <mark.rutland@arm.com> - 2017-04-26 11:10 +0200
      Re: [patch V2 00/24] cpu/hotplug: Convert get_online_cpus() to a  percpu_rwsem Suzuki K Poulose <Suzuki.Poulose@arm.com> - 2017-04-26 12:00 +0200
        Re: [patch V2 00/24] cpu/hotplug: Convert get_online_cpus() to a  percpu_rwsem Mark Rutland <mark.rutland@arm.com> - 2017-04-26 12:40 +0200
          Re: [patch V2 00/24] cpu/hotplug: Convert get_online_cpus() to a  percpu_rwsem Sebastian Siewior <bigeasy@linutronix.de> - 2017-04-27 10:30 +0200
            Re: [patch V2 00/24] cpu/hotplug: Convert get_online_cpus() to a  percpu_rwsem Mark Rutland <mark.rutland@arm.com> - 2017-04-27 12:00 +0200
              Re: [patch V2 00/24] cpu/hotplug: Convert get_online_cpus() to a  percpu_rwsem Thomas Gleixner <tglx@linutronix.de> - 2017-04-27 12:10 +0200
                Re: [patch V2 00/24] cpu/hotplug: Convert get_online_cpus() to a  percpu_rwsem Mark Rutland <mark.rutland@arm.com> - 2017-04-27 14:40 +0200
                [PATCH] arm64: cpufeature: use static_branch_enable_cpuslocked()  (was: Re: [patch V2 00/24] cpu/hotplug: Convert get_online_cpus() to a  percpu_rwsem) Mark Rutland <mark.rutland@arm.com> - 2017-04-27 17:50 +0200
                Re: [PATCH] arm64: cpufeature: use static_branch_enable_cpuslocked()  (was: Re: [patch V2 00/24] cpu/hotplug: Convert get_online_cpus() to a  percpu_rwsem) Suzuki K Poulose <Suzuki.Poulose@arm.com> - 2017-04-27 18:40 +0200
                Re: [PATCH] arm64: cpufeature: use static_branch_enable_cpuslocked() Suzuki K Poulose <Suzuki.Poulose@arm.com> - 2017-04-27 19:10 +0200
                Re: [PATCH] arm64: cpufeature: use static_branch_enable_cpuslocked() Mark Rutland <mark.rutland@arm.com> - 2017-04-27 19:20 +0200

csiph-web