[PATCH] ASoC: Intel: Skylake: use dev in dev_err rather than skl pointer

From	Colin King <colin.king@canonical.com>
Newsgroups	linux.kernel
Subject	[PATCH] ASoC: Intel: Skylake: use dev in dev_err rather than skl pointer
Date	2017-04-27 17:20 +0200
Message-ID	<tATn3-2pt-3@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Colin Ian King <colin.king@canonical.com>

The dev_err message is dereferencing an uininitialized skl pointer
which should be avoided. Don't use skl, use dev instead.

Detected by CoverityScan, CID#1432042 ("Uninitialized pointer read")

Fixes: 9fe9c71192832 ("ASoC: Intel: Skylake: Move sst common initialization to a helper function")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 sound/soc/intel/skylake/bxt-sst.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/intel/skylake/bxt-sst.c b/sound/soc/intel/skylake/bxt-sst.c
index fde4bc0f35b0..f5e7dbb1ba39 100644
--- a/sound/soc/intel/skylake/bxt-sst.c
+++ b/sound/soc/intel/skylake/bxt-sst.c
@@ -564,7 +564,7 @@ int bxt_sst_dsp_init(struct device *dev, void __iomem *mmio_base, int irq,
 
 	ret = skl_sst_ctx_init(dev, irq, fw_name, dsp_ops, dsp, &skl_dev);
 	if (ret < 0) {
-		dev_err(skl->dev, "%s: no device\n", __func__);
+		dev_err(dev, "%s: no device\n", __func__);
 		return ret;
 	}
 
-- 
2.11.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] ASoC: Intel: Skylake: use dev in dev_err rather than skl pointer Colin King <colin.king@canonical.com> - 2017-04-27 17:20 +0200
  Re: [PATCH] ASoC: Intel: Skylake: use dev in dev_err rather than skl  pointer Takashi Sakamoto <o-takashi@sakamocchi.jp> - 2017-04-28 00:40 +0200

csiph-web