Re: [PATCH] ASoC: Intel: Skylake: fix uninitialized pointer use

From	Vinod Koul <vinod.koul@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ASoC: Intel: Skylake: fix uninitialized pointer use
Date	2017-04-27 16:30 +0200
Message-ID	<tASAH-1Ma-27@gated-at.bofh.it> (permalink)
References	<tAPt7-86a-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Apr 27, 2017 at 12:59:58PM +0200, Arnd Bergmann wrote:
> The error handling in bxt_sst_dsp_init() got changed in a way that
> it now derefences an uninitialized pointer when printing a warning
> about the device not being found:
> 
> sound/soc/intel/skylake/bxt-sst.c: In function 'bxt_sst_dsp_init':
> sound/soc/intel/skylake/bxt-sst.c:567:14: error: 'skl' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> 
> As we do have a valid device pointer available at the call site,
> let's use that instead.

Thanks Arnd for this fix, but this was also reported by SFR earlier today
and have pasoted same patch via
http://mailman.alsa-project.org/pipermail/alsa-devel/2017-April/120214.html

Patches are same, so Mark can take either :)

-- 
~Vinod

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ASoC: Intel: Skylake: fix uninitialized pointer use Arnd Bergmann <arnd@arndb.de> - 2017-04-27 13:10 +0200
  Re: [PATCH] ASoC: Intel: Skylake: fix uninitialized pointer use Takashi Sakamoto <o-takashi@sakamocchi.jp> - 2017-04-27 13:20 +0200
  Re: [PATCH] ASoC: Intel: Skylake: fix uninitialized pointer use Vinod Koul <vinod.koul@intel.com> - 2017-04-27 16:30 +0200

csiph-web