Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1632049
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2] pid_ns: Introduce ioctl to set vector of ns_last_pid's on ns hierarhy |
| Date | 2017-04-27 14:00 +0200 |
| Message-ID | <tAQfv-8w0-1@gated-at.bofh.it> (permalink) |
| References | <tAQfv-8w0-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Apr 27, 2017 at 01:57:16PM +0300, Kirill Tkhai wrote:
> --- a/include/uapi/linux/nsfs.h
> +++ b/include/uapi/linux/nsfs.h
> @@ -14,5 +14,12 @@
> #define NS_GET_NSTYPE _IO(NSIO, 0x3)
> /* Get owner UID (in the caller's user namespace) for a user namespace */
> #define NS_GET_OWNER_UID _IO(NSIO, 0x4)
> +/* Set a vector of ns_last_pid for a pid namespace stack */
> +#define NS_SET_LAST_PID_VEC _IO(NSIO, 0x5)
> +
> +struct ns_ioc_pid_vec {
> + unsigned int nr;
Please make this an explicit type, variables that cross the user/kernel
boundry should be using __u32 and friends, not vague things like "int".
thanks,
greg k-h
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [PATCH v2] pid_ns: Introduce ioctl to set vector of ns_last_pid's on ns hierarhy Greg KH <gregkh@linuxfoundation.org> - 2017-04-27 14:00 +0200
csiph-web