Groups > linux.kernel > #1632073

Re: [PATCH v2 9/9] KVM: mark requests that need synchronization

From	Paolo Bonzini <pbonzini@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 9/9] KVM: mark requests that need synchronization
Date	2017-04-27 14:40 +0200
Message-ID	<tAQSe-Bq-11@gated-at.bofh.it> (permalink)
References	<tABTb-7dC-3@gated-at.bofh.it> <tABTb-7dC-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 26/04/2017 22:32, Radim Krčmář wrote:
>  v2: replaces [v1 1/6]
>      Ugh, KVM_ARCH_REQ_WAIT_NO_WAKEUP looks a weird ...

Yeah, let's drop patch 7 and just use bits for now.  I think using
KVM_ARCH_REQ_FLAGS directly should be fine, especially after the default
is flipped from "no wakeup" to "wakeup", but for 4.12 this is the
simplest incremental step.

> +/* TODO: merge with kvm_arch_vcpu_should_kick */
> +static bool kvm_should_kick_request(struct kvm_vcpu *vcpu, unsigned req)

I'm renaming this to kvm_request_needs_ipi; the point of the IPI for
synchronous requests is not the "kick", but the "ack" that comes back.

Paolo

> +{
> +	int mode = kvm_vcpu_exiting_guest_mode(vcpu);
> +
> +	return req & KVM_REQUEST_WAIT ?
> +		mode != OUTSIDE_GUEST_MODE : mode == IN_GUEST_MODE;
> +}
> +

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 9/9] KVM: mark requests that need synchronization Radim Krčmář <rkrcmar@redhat.com> - 2017-04-26 22:40 +0200
  Re: [PATCH v2 9/9] KVM: mark requests that need synchronization Andrew Jones <drjones@redhat.com> - 2017-04-27 14:00 +0200
  Re: [PATCH v2 9/9] KVM: mark requests that need synchronization Paolo Bonzini <pbonzini@redhat.com> - 2017-04-27 14:40 +0200

csiph-web