Groups > linux.kernel > #1631984

[PATCH] usb: gadget: udc-xilinx: clean up a variable name

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	[PATCH] usb: gadget: udc-xilinx: clean up a variable name
Date	2017-04-27 11:20 +0200
Message-ID	<tANKG-6Ty-15@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

"ep->udc->lock" and "udc->lock" are the same thing.  It confuses Smatch
if we don't use the same name consistently.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/usb/gadget/udc/udc-xilinx.c b/drivers/usb/gadget/udc/udc-xilinx.c
index 588e2531b8b8..de207a90571e 100644
--- a/drivers/usb/gadget/udc/udc-xilinx.c
+++ b/drivers/usb/gadget/udc/udc-xilinx.c
@@ -1151,7 +1151,7 @@ static int xudc_ep_dequeue(struct usb_ep *_ep, struct usb_request *_req)
 			break;
 	}
 	if (&req->usb_req != _req) {
-		spin_unlock_irqrestore(&ep->udc->lock, flags);
+		spin_unlock_irqrestore(&udc->lock, flags);
 		return -EINVAL;
 	}
 	xudc_done(ep, req, -ECONNRESET);

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH] usb: gadget: udc-xilinx: clean up a variable name Dan Carpenter <dan.carpenter@oracle.com> - 2017-04-27 11:20 +0200

csiph-web