Groups > linux.kernel > #1631946

Re: [PATCH] perf/x86/intel/pt: Allow disabling branch tracing

Path	csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Adrian Hunter <adrian.hunter@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] perf/x86/intel/pt: Allow disabling branch tracing
Date	Thu, 27 Apr 2017 10:20:02 +0200
Message-ID	<tAMOC-6i9-19@gated-at.bofh.it> (permalink)
References	<t6mEF-2zZ-7@gated-at.bofh.it> <t7SM9-6cu-1@gated-at.bofh.it> <t7TRU-6RC-21@gated-at.bofh.it> <t7U1z-7ak-5@gated-at.bofh.it> <t7V7j-7WF-5@gated-at.bofh.it>
X-Original-To	Andi Kleen <andi@firstfloor.org>, Alexander Shishkin <alexander.shishkin@linux.intel.com>
X-Extloop1	1
X-Ironport-Av	E=Sophos;i="5.37,257,1488873600"; d="scan'208";a="961662139"
Organization	Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0
MIME-Version	1.0
Content-Type	text/plain; charset=windows-1252
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	32
X-Original-Cc	Peter Zijlstra <a.p.zijlstra@chello.nl>, Ingo Molnar <mingo@redhat.com>, linux-kernel@vger.kernel.org, vince@deater.net, eranian@google.com, Arnaldo Carvalho de Melo <acme@infradead.org>, Borislav Petkov <bp@suse.de>, Thomas Gleixner <tglx@linutronix.de>
X-Original-Date	Thu, 27 Apr 2017 11:11:30 +0300
X-Original-Message-ID	<2cb2bf69-49d2-cf82-ccf8-8069741fe691@intel.com>
X-Original-References	<87inosaoi1.fsf@ashishki-desk.ger.corp.intel.com> <20170206144140.14402-1-alexander.shishkin@linux.intel.com> <87efzbjopq.fsf@firstfloor.org> <87mvdz8fue.fsf@ashishki-desk.ger.corp.intel.com> <20170206171921.GG26852@two.firstfloor.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1631946

Show key headers only | View raw

On 06/02/17 19:19, Andi Kleen wrote:
> On Mon, Feb 06, 2017 at 06:05:29PM +0200, Alexander Shishkin wrote:
>> Andi Kleen <andi@firstfloor.org> writes:
>>
>>> Alexander Shishkin <alexander.shishkin@linux.intel.com> writes:
>>>
>>>> Now that Intel PT supports more types of trace content than just branch
>>>> tracing, it may be useful to allow the user to disable branch tracing
>>>> when it is not needed.
>>>>
>>>> The special case is BDW, where not setting BranchEn is not supported.
>>>>
>>>> This is slightly trickier than necessary, because up to this moment
>>>> the driver has been setting BranchEn automatically and the userspace
>>>> assumes as much. Instead of reversing the semantics of BranchEn, we
>>>> introduce a 'passthrough' bit, which will forego the default and allow
>>>> the user to set BranchEn to their heart's content.
>>>
>>> cpu/passthrough=1,branchen=1/ seems far uglier/more complicanted to me
>>> than the original cpu/nobranch=1/
>>
>> It's /passthrough=1,branch=0/ or simply /passthrough=1/.
> 
> Ok, but still you have to list exactly to which flags passthrough
> applies to, and it will only ever be branchen.

It doesn't have to be that bad.

For Intel PT, perf tools already provides default config which the user must
override.  So, when 'passthrough' is supported, the default config would
include 'passthrough=1,branch=1'.  So then the user would only have to put
'branch=0' when they want no branches.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] perf/x86/intel/pt: Allow disabling branch tracing Adrian Hunter <adrian.hunter@intel.com> - 2017-04-27 10:20 +0200

csiph-web