Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1631913

Re: [PATCH v2] clk: sunxi-ng: Fix dependency on SUNXI_CCU_GATE

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, Apr 26, 2017 at 01:53:19PM +0200, Corentin Labbe wrote:
> When CONFIG_SUNXI_CCU is set but no other SUNXI_CCU is selected i got
> the following build error:
> drivers/built-in.o: In function `ccu_pll_notifier_cb':
> drivers/clk/sunxi-ng/ccu_common.c:71: undefined reference to `ccu_gate_helper_disable'
> drivers/clk/sunxi-ng/ccu_common.c:73: undefined reference to `ccu_gate_helper_enable'
> 
> The problem is the function ccu_pll_notifier_cb in ccu_common.c need
> some function from ccu_gate.c which is not compiled since SUNXI_CCU_GATE
> is not selected.
> 
> This patch remove SUNXI_CCU_GATE and compile ccu_gate.c unconditionnaly
> since all other combination of options select SUNXI_CCU_GATE finally.
> 
> Fixes: 02ae2bc6febd ("clk: sunxi-ng: Add clk notifier to gate then ungate PLL clocks")
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>

I think Chen-Yu had some comments that you didn't address.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] clk: sunxi-ng: Fix dependency on SUNXI_CCU_GATE Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-04-26 14:00 +0200
  Re: [PATCH v2] clk: sunxi-ng: Fix dependency on SUNXI_CCU_GATE Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-04-27 09:10 +0200
    Re: [PATCH v2] clk: sunxi-ng: Fix dependency on SUNXI_CCU_GATE Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-04-27 10:20 +0200
      Re: [PATCH v2] clk: sunxi-ng: Fix dependency on SUNXI_CCU_GATE Stephen Boyd <sboyd@codeaurora.org> - 2017-04-28 03:20 +0200
        Re: [PATCH v2] clk: sunxi-ng: Fix dependency on SUNXI_CCU_GATE Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-04-28 14:10 +0200

csiph-web