Re: [PATCH v2] NFC: trf7970a: Correct register settings for 27MHz clock

From	Mark Greer <mgreer@animalcreek.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] NFC: trf7970a: Correct register settings for 27MHz clock
Date	2017-04-27 06:10 +0200
Message-ID	<tAIUF-3zP-5@gated-at.bofh.it> (permalink)
References	<tAGJb-226-1@gated-at.bofh.it>
Organization	Animal Creek Technologies, Inc.

Show all headers | View raw

On Wed, Apr 26, 2017 at 09:41:48PM -0400, Geoff Lansberry wrote:

Hi Geoff.

> In prior commits the selected clock frequency does not propagate
> correctly to what is written the the TRF7970A_MODULATOR_SYS_CLK_CTRL
> register.
> 
> Signed-off-by: Geoff Lansberry <geoff@kuvee.com>
> ---
>  drivers/nfc/trf7970a.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/nfc/trf7970a.c b/drivers/nfc/trf7970a.c
> index 5f040e6..c278b0e 100644
> --- a/drivers/nfc/trf7970a.c
> +++ b/drivers/nfc/trf7970a.c
> @@ -2079,6 +2079,13 @@ static int trf7970a_probe(struct spi_device *spi)
>  		return -EINVAL;
>  	}
>  
> +	if (clk_freq == TRF7970A_27MHZ_CLOCK_FREQUENCY) {
> +		trf->modulator_sys_clk_ctrl = TRF7970A_MODULATOR_27MHZ;
> +		dev_dbg(trf->dev, "trf7970a configured for 27MHz crystal\n");
> +	} else {
> +		trf->modulator_sys_clk_ctrl = 0;
> +	}
> +
>  	if (of_property_read_bool(np, "en2-rf-quirk"))
>  		trf->quirks |= TRF7970A_QUIRK_EN2_MUST_STAY_LOW;

Looks fine to me but please rebase it on top of current nfc-next/master
as it doesn't apply to it right now.

Thanks,

Mark
--

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] NFC: trf7970a: Correct register settings for 27MHz clock Geoff Lansberry <geoff@kuvee.com> - 2017-04-27 03:50 +0200
  Re: [PATCH v2] NFC: trf7970a: Correct register settings for 27MHz  clock Mark Greer <mgreer@animalcreek.com> - 2017-04-27 06:10 +0200

csiph-web