Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1631742

Re: [PATCH] gpiolib: Add stubs for gpiod lookup table interface

Show all headers | View raw

On Mon, Apr 24, 2017 at 5:04 PM, Anatolij Gustschin <agust@denx.de> wrote:
> Add stubs for gpiod_add_lookup_table() and gpiod_remove_lookup_table()
> for the !GPIOLIB case to prevent build errors. Also add prototypes.

One nit below, otherwise
FWIW:
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

Linus, it would be nice if are okay with this approach. It will fix
that one user which might break a buiid on some kernel configurations.

>
> Signed-off-by: Anatolij Gustschin <agust@denx.de>
> ---
>  include/linux/gpio/consumer.h | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
>
> diff --git a/include/linux/gpio/consumer.h b/include/linux/gpio/consumer.h
> index 933d936..6c0cc67 100644
> --- a/include/linux/gpio/consumer.h
> +++ b/include/linux/gpio/consumer.h
> @@ -144,6 +144,11 @@ struct gpio_desc *devm_fwnode_get_index_gpiod_from_child(struct device *dev,
>                                                 enum gpiod_flags flags,
>                                                 const char *label);

> +struct gpiod_lookup_table;

>  #else /* CONFIG_GPIOLIB */

> +struct gpiod_lookup_table;

No need to duplicate this. Just move out of #ifdef.

-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] gpiolib: Add stubs for gpiod lookup table interface Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-04-26 23:40 +0200

csiph-web