Re: [PATCH v4] Staging: most: use func instead of the function name

From	Chandra Annamaneni <chandra627@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4] Staging: most: use __func__ instead of the function name
Date	2017-04-26 23:30 +0200
Message-ID	<tACFz-7Oy-11@gated-at.bofh.it> (permalink)
References	<tAuRI-2H8-9@gated-at.bofh.it> <tAvNM-3kF-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Sorry!
And thanks for pointing it out.

regards
Chandra

On Wed, 26 Apr 2017, Dan Carpenter wrote:

> On Wed, Apr 26, 2017 at 06:02:29AM -0700, Chandra Annamaneni wrote:
> > 
> > Change video.c to use %s, __func__ instead of function names.
> > Warnings flagged by checkpatch.pl
> > 
> > Signed-off-by: Chandra Annamaneni <chandra627@gmail.com>
> > 
> > diff --git a/drivers/staging/most/aim-v4l2/video.c b/drivers/staging/most/aim-v4l2/video.c
> > index 59e861e..e074841 100644
> > --- a/drivers/staging/most/aim-v4l2/video.c
> > +++ b/drivers/staging/most/aim-v4l2/video.c
> > @@ -79,7 +79,7 @@ static int aim_vdev_open(struct file *filp)
> >  	struct most_video_dev *mdev = video_drvdata(filp);
> >  	struct aim_fh *fh;
> > 
> > -	v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);
> > +	v4l2_info(&mdev->v4l2_dev, "aim_vdev_open()\n");
> 
> You sent the reversed patch.
> 
> regards,
> dan carpenter
> 
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v4] Staging: most: use __func__ instead of the function  name Chandra Annamaneni <chandra627@gmail.com> - 2017-04-26 15:10 +0200
  Re: [PATCH v4] Staging: most: use __func__ instead of the function  name Dan Carpenter <dan.carpenter@oracle.com> - 2017-04-26 16:10 +0200
    Re: [PATCH v4] Staging: most: use __func__ instead of the function  name Chandra Annamaneni <chandra627@gmail.com> - 2017-04-26 23:30 +0200

csiph-web