Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1631662

Re: [PATCH v1] net: phy: fix auto-negotiation stall due to unavailable interrupt

From David Miller <davem@davemloft.net>
Newsgroups linux.kernel
Subject Re: [PATCH v1] net: phy: fix auto-negotiation stall due to unavailable interrupt
Date 2017-04-26 20:40 +0200
Message-ID <tAA15-61F-33@gated-at.bofh.it> (permalink)
References <tyi8h-8cx-1@gated-at.bofh.it> <tyi8i-8cx-33@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Alexander Kochetkov <al.kochet@gmail.com>
Date: Thu, 20 Apr 2017 14:00:04 +0300

> The Ethernet link on an interrupt driven PHY was not coming up if the Ethernet
> cable was plugged before the Ethernet interface was brought up.
> 
> The patch trigger PHY state machine to update link state if PHY was requested to
> do auto-negotiation and auto-negotiation complete flag already set.
> 
> During power-up cycle the PHY do auto-negotiation, generate interrupt and set
> auto-negotiation complete flag. Interrupt is handled by PHY state machine but
> doesn't update link state because PHY is in PHY_READY state. After some time
> MAC bring up, start and request PHY to do auto-negotiation. If there are no new
> settings to advertise genphy_config_aneg() doesn't start PHY auto-negotiation.
> PHY continue to stay in auto-negotiation complete state and doesn't fire
> interrupt. At the same time PHY state machine expect that PHY started
> auto-negotiation and is waiting for interrupt from PHY and it won't get it.
> 
> Signed-off-by: Alexander Kochetkov <al.kochet@gmail.com>
> Cc: stable <stable@vger.kernel.org> # v4.9+

Applied, and I reverted the micrel commit too.

Thanks.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH v1] net: phy: fix auto-negotiation stall due to  unavailable interrupt David Miller <davem@davemloft.net> - 2017-04-26 20:40 +0200

csiph-web