Re: [PATCH 3/3] HSI: omap_ssi: Delete an error message for a failed memory allocation in ssi_add_controller()

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] HSI: omap_ssi: Delete an error message for a failed memory allocation in ssi_add_controller()
Date	2017-04-25 14:40 +0200
Message-ID	<tA7V7-4Ib-1@gated-at.bofh.it> (permalink)
References	<tA6FI-3Yq-5@gated-at.bofh.it> <tA6FI-3Yq-3@gated-at.bofh.it> <tA7ip-4eL-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

1) That allocation will never fail in real life so it's dead code.
2) kmalloc and friends already have much better builtin in error
   messages so it's useless.
3) There is a small memory savings from removing it.

I'm not saying you should apply the patch, I'm just saying that these
messages are pointless and detrimental.

regards,
an carpenter

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/3] HSI: omap_ssi: Delete an error message for a failed  memory allocation in ssi_add_controller() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-25 13:20 +0200
  Re: [PATCH 3/3] HSI: omap_ssi: Delete an error message for a failed  memory allocation in ssi_add_controller() Pavel Machek <pavel@ucw.cz> - 2017-04-25 14:00 +0200
    Re: [PATCH 3/3] HSI: omap_ssi: Delete an error message for a failed  memory allocation in ssi_add_controller() Dan Carpenter <dan.carpenter@oracle.com> - 2017-04-25 14:40 +0200

csiph-web