Re: [RFC 2/2] mm: skip HWPoisoned pages when onlining pages

From	Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Newsgroups	linux.kernel
Subject	Re: [RFC 2/2] mm: skip HWPoisoned pages when onlining pages
Date	2017-04-25 10:10 +0200
Message-ID	<tA3HP-24M-7@gated-at.bofh.it> (permalink)
References	<tygzv-7a4-1@gated-at.bofh.it> <tygzv-7a4-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Apr 20, 2017 at 11:26:02AM +0200, Laurent Dufour wrote:
> The commit b023f46813cd ("memory-hotplug: skip HWPoisoned page when
> offlining pages") skip the HWPoisoned pages when offlining pages, but
> this should be skipped when onlining the pages too.
>
> Signed-off-by: Laurent Dufour <ldufour@linux.vnet.ibm.com>
> ---
>  mm/memory_hotplug.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index 6fa7208bcd56..20e1fadc2369 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -942,6 +942,8 @@ static int online_pages_range(unsigned long start_pfn, unsigned long nr_pages,
>  	if (PageReserved(pfn_to_page(start_pfn)))
>  		for (i = 0; i < nr_pages; i++) {
>  			page = pfn_to_page(start_pfn + i);
> +			if (PageHWPoison(page))
> +				continue;

Is it OK that PageReserved (set by __offline_isolated_pages for non-buddy
hwpoisoned pages) still remains in this path?
If online_pages_range() is the reverse operation of __offline_isolated_pages(),
ClearPageReserved seems needed here.

Thanks,
Naoya Horiguchi

>  			(*online_page_callback)(page);
>  			onlined_pages++;
>  		}
> --
> 2.7.4
>
>

Thread

[RFC 0/2] BUG raised when onlining HWPoisoned page Laurent Dufour <ldufour@linux.vnet.ibm.com> - 2017-04-20 11:30 +0200
  [RFC 2/2] mm: skip HWPoisoned pages when onlining pages Laurent Dufour <ldufour@linux.vnet.ibm.com> - 2017-04-20 11:30 +0200
    Re: [RFC 2/2] mm: skip HWPoisoned pages when onlining pages Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> - 2017-04-25 10:10 +0200
      Re: [RFC 2/2] mm: skip HWPoisoned pages when onlining pages Laurent Dufour <ldufour@linux.vnet.ibm.com> - 2017-04-25 16:20 +0200
  [RFC 1/2] mm: Uncharge poisoned pages Laurent Dufour <ldufour@linux.vnet.ibm.com> - 2017-04-20 11:30 +0200
    Re: [RFC 1/2] mm: Uncharge poisoned pages Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> - 2017-04-24 11:10 +0200
      Re: [RFC 1/2] mm: Uncharge poisoned pages Laurent Dufour <ldufour@linux.vnet.ibm.com> - 2017-04-24 15:20 +0200

csiph-web