Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1630204

[PATCH v2 4/4] of: detect invalid phandle in overlay

Show all headers | View raw

From: Frank Rowand <frank.rowand@sony.com>

Overlays are not allowed to modify phandle values of previously existing
nodes because there is no information available to allow fixup up
properties that use the previously existing phandle.

Signed-off-by: Frank Rowand <frank.rowand@sony.com>
---
 drivers/of/overlay.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c
index ca0b85f5deb1..20ab49d2f7a4 100644
--- a/drivers/of/overlay.c
+++ b/drivers/of/overlay.c
@@ -130,6 +130,10 @@ static int of_overlay_apply_single_device_node(struct of_overlay *ov,
 	/* NOTE: Multiple mods of created nodes not supported */
 	tchild = of_get_child_by_name(target, cname);
 	if (tchild != NULL) {
+		/* new overlay phandle value conflicts with existing value */
+		if (child->phandle)
+			return -EINVAL;
+
 		/* apply overlay recursively */
 		ret = of_overlay_apply_one(ov, tchild, child);
 		of_node_put(tchild);
-- 
Frank Rowand <frank.rowand@sony.com>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/4] of: remove *phandle properties from expanded device tree frowand.list@gmail.com - 2017-04-25 08:30 +0200
  [PATCH v2 4/4] of: detect invalid phandle in overlay frowand.list@gmail.com - 2017-04-25 08:30 +0200
  [PATCH v2 2/4] of: make __of_attach_node() static frowand.list@gmail.com - 2017-04-25 08:30 +0200
  [PATCH v2 1/4] of: remove *phandle properties from expanded device tree frowand.list@gmail.com - 2017-04-25 08:30 +0200
  [PATCH v2 3/4] of: be consistent in form of file mode frowand.list@gmail.com - 2017-04-25 08:30 +0200

csiph-web