Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1578920

Re: [RFC PATCH 2/2] mm/sparse: add last_section_nr in sparse_init() to reduce some iteration cycle

Show all headers | View raw

Hello,

On Sat, Feb 11, 2017 at 10:18:29AM +0800, Wei Yang wrote:
> During the sparse_init(), it iterate on each possible section. On x86_64,
> it would always be (2^19) even there is not much memory. For example, on a
> typical 4G machine, it has only (2^5) to (2^6) present sections. This
> benefits more on a system with smaller memory.
> 
> This patch calculates the last section number from the highest pfn and use
> this as the boundary of iteration.

* How much does this actually matter?  Can you measure the impact?

* Do we really need to add full reverse iterator to just get the
  highest section number?

Thanks.

-- 
tejun

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [RFC PATCH 2/2] mm/sparse: add last_section_nr in sparse_init()  to reduce some iteration cycle Tejun Heo <tj@kernel.org> - 2017-02-11 03:30 +0100
  Re: [RFC PATCH 2/2] mm/sparse: add last_section_nr in sparse_init()  to reduce some iteration cycle Wei Yang <richard.weiyang@gmail.com> - 2017-02-13 14:10 +0100

csiph-web