RE: [PATCH] checkpatch: add warning on %pk instead of %pK usage

From	"Roberts, William C" <william.c.roberts@intel.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH] checkpatch: add warning on %pk instead of %pK usage
Date	2017-02-11 02:40 +0100
Message-ID	<t9uPo-2IM-17@gated-at.bofh.it> (permalink)
References	<t9pd0-7Ix-23@gated-at.bofh.it> <t9pPH-8bb-7@gated-at.bofh.it> <t9rHQ-U6-11@gated-at.bofh.it> <t9rRv-Xp-1@gated-at.bofh.it> <t9sky-17u-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

<snip>
> > By "normal" I'm referring to things that call into pointer(), just
> > casually looking I see bstr_printf vsnprintf kvasprintf, which would
> > be easy enough to add
> >
> > > What do you think is missing?  sn?printf ? That's easy to add.
> >
> > The problem starts to get hairy when we think of how often folks roll
> > their own logging macros (see some small sampling at the end).
> >
> > I think we would want to add DEBUG DBG and sn?printf and maybe
> > consider dropping the \b on the regex so it's a bit more matchy but
> > still shouldn't end up matching on any ASM as you pointed out in the V2 nack.
> >
> > Ill break this down into:
> > 1. the patch as I know you'll take it, as you wrote it :-P 2. Adding
> > to the logging macros 3. exploring making it less matchy

-Kees and Andrew they likely don't care about the rest of this...

I have been working up a regex (I suck at these) to match C functions that have an invalid
%p format string and take arguments:
http://www.regexr.com/3f92k

This could be a way to get better coverage in a more generic approach, thoughts?

Thread

[PATCH] checkpatch: add warning on %pk instead of %pK usage william.c.roberts@intel.com - 2017-02-10 20:40 +0100
  Re: [PATCH] checkpatch: add warning on %pk instead of %pK usage Joe Perches <joe@perches.com> - 2017-02-10 21:20 +0100
    RE: [PATCH] checkpatch: add warning on %pk instead of %pK usage "Roberts, William C" <william.c.roberts@intel.com> - 2017-02-10 23:20 +0100
      RE: [PATCH] checkpatch: add warning on %pk instead of %pK usage "Roberts, William C" <william.c.roberts@intel.com> - 2017-02-10 23:30 +0100
        Re: [PATCH] checkpatch: add warning on %pk instead of %pK usage Joe Perches <joe@perches.com> - 2017-02-11 00:00 +0100
          Re: [PATCH] checkpatch: add warning on %pk instead of %pK usage Joe Perches <joe@perches.com> - 2017-02-11 00:00 +0100
          RE: [PATCH] checkpatch: add warning on %pk instead of %pK usage "Roberts, William C" <william.c.roberts@intel.com> - 2017-02-11 00:40 +0100
            Re: [PATCH] checkpatch: add warning on %pk instead of %pK usage Joe Perches <joe@perches.com> - 2017-02-11 00:50 +0100
          RE: [PATCH] checkpatch: add warning on %pk instead of %pK usage "Roberts, William C" <william.c.roberts@intel.com> - 2017-02-11 01:00 +0100
            Re: [PATCH] checkpatch: add warning on %pk instead of %pK usage Joe Perches <joe@perches.com> - 2017-02-11 01:10 +0100
          RE: [PATCH] checkpatch: add warning on %pk instead of %pK usage "Roberts, William C" <william.c.roberts@intel.com> - 2017-02-11 02:40 +0100
            Re: [PATCH] checkpatch: add warning on %pk instead of %pK usage Joe Perches <joe@perches.com> - 2017-02-11 04:30 +0100

csiph-web