[PATCH] ubifs: Fix memory leak in error path in ubifs_mknod

From	Richard Weinberger <richard@nod.at>
Newsgroups	linux.kernel
Subject	[PATCH] ubifs: Fix memory leak in error path in ubifs_mknod
Date	2017-02-10 20:20 +0100
Message-ID	<t9oTD-7BA-1@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

When fscrypt_setup_filename() fails we have to free dev.

Signed-off-by: Richard Weinberger <richard@nod.at>
---
 fs/ubifs/dir.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/fs/ubifs/dir.c b/fs/ubifs/dir.c
index 528369f3e472..e164782f8bc8 100644
--- a/fs/ubifs/dir.c
+++ b/fs/ubifs/dir.c
@@ -1068,8 +1068,10 @@ static int ubifs_mknod(struct inode *dir, struct dentry *dentry,
 	}
 
 	err = fscrypt_setup_filename(dir, &dentry->d_name, 0, &nm);
-	if (err)
+	if (err) {
+		kfree(dev);
 		goto out_budg;
+	}
 
 	sz_change = CALC_DENT_SIZE(fname_len(&nm));
 
-- 
2.10.2

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH] ubifs: Fix memory leak in error path in ubifs_mknod Richard Weinberger <richard@nod.at> - 2017-02-10 20:20 +0100

csiph-web