Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1578637
| From | Joe Perches <joe@perches.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] staging: bcm2835-audio: fix trailing statements |
| Date | 2017-02-10 18:30 +0100 |
| Message-ID | <t9nbb-6qo-11@gated-at.bofh.it> (permalink) |
| References | <t9m5s-5JI-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, 2017-02-10 at 17:14 +0100, AbdAllah-MEZITI wrote:
> Trailing statements should be on next line.
[]
> diff --git a/drivers/staging/bcm2835-audio/bcm2835-vchiq.c b/drivers/staging/bcm2835-audio/bcm2835-vchiq.c
[]
> @@ -563,7 +563,8 @@ int bcm2835_audio_set_ctls(struct bcm2835_chip *chip)
> } else if (bcm2835_audio_set_ctls_chan(chip->alsa_stream[i], chip) != 0) {
> LOG_ERR("Couldn't set the controls for stream %d\n", i);
> ret = -1;
> - } else LOG_DBG(" Controls set for stream %d\n", i);
> + } else
> + LOG_DBG(" Controls set for stream %d\n", i);
> }
> }
> LOG_DBG(" .. OUT ret=%d\n", ret);
It's curious that checkpatch doesn't catch this and
ideally this would also use braces for the last else.
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH] staging: bcm2835-audio: fix trailing statements AbdAllah-MEZITI <abdallah.meziti.pro@gmail.com> - 2017-02-10 17:20 +0100 Re: [PATCH] staging: bcm2835-audio: fix trailing statements Joe Perches <joe@perches.com> - 2017-02-10 18:30 +0100
csiph-web