Re: [PATCH v2] staging: rtl8712: rtl8712: fixed missing conversion to le32

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] staging: rtl8712: rtl8712: fixed missing conversion to le32
Date	2017-02-10 18:20 +0100
Message-ID	<t9n1w-6mA-11@gated-at.bofh.it> (permalink)
References	<t8U9b-4Wt-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Feb 09, 2017 at 10:18:42AM +0000, Carlos Palminha wrote:
> Fixed missing conversion to le32, detected by sparse
> (invalid assignment from int to __le32)
> 
> Signed-off-by: Carlos Palminha <palminha@synopsys.com>
> ---
> v1->v2:
> missed sob line (too late in the night...)
> 
>  drivers/staging/rtl8712/rtl8712_xmit.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8712/rtl8712_xmit.c b/drivers/staging/rtl8712/rtl8712_xmit.c
> index 041508d6ec6d..4231a0a83097 100644
> --- a/drivers/staging/rtl8712/rtl8712_xmit.c
> +++ b/drivers/staging/rtl8712/rtl8712_xmit.c
> @@ -573,7 +573,7 @@ static void update_txdesc(struct xmit_frame *pxmitframe, uint *pmem, int sz)
>  		}
>  	} else if (pxmitframe->frame_tag == MGNT_FRAMETAG) {
>  		/* offset 4 */
> -		ptxdesc->txdw1 |= (0x05) & 0x1f;/*CAM_ID(MAC_ID), default=5;*/
> +		ptxdesc->txdw1 |= cpu_to_le32((0x05) & 0x1f);/*CAM_ID(MAC_ID), default=5;*/

This looks reasonable but it's probably cleaner to say something like:

		ptxdesc->txdw1 |= cpu_to_le32(0x05); /*CAM_ID(MAC_ID), default=5;*/

regards,
dan carpenter

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] staging: rtl8712: rtl8712: fixed missing conversion to le32 Carlos Palminha <CARLOS.PALMINHA@synopsys.com> - 2017-02-09 11:30 +0100
  Re: [PATCH v2] staging: rtl8712: rtl8712: fixed missing conversion  to le32 Dan Carpenter <dan.carpenter@oracle.com> - 2017-02-10 18:20 +0100

csiph-web