Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1578528

Re: [PATCH v2 0/4] New Microsemi PCI Switch Management Driver

Show all headers | View raw

On Thu, Feb 02, 2017 at 11:05:59AM -0700, Logan Gunthorpe wrote:
> Changes since v1:
> 
> * Rebased onto 4.10-rc6 (cleanly)
> * Split the patch into a few more easily digestible patches (as
>   suggested by Greg Kroah-Hartman)
> * Folded switchtec.c into switchtec.h (per Greg)
> * Fixed a bunch of 32bit build warnings caught by the kbuild test robot
> * Fixed some issues in the documentation so it has a proper
>   reStructredText format (as noted by Jonathan Corbet)
> * Fixed padding and sizes in the IOCTL structures as noticed by Emil
>   Velikov and used pahole to verify their consistency across 32 and 64
>   bit builds
> * Reworked one of the IOCTL interfaces to be more future proof (per
>   Emil).
> 
> Changes since RFC:
> 
> * Fixed incorrect use of the drive model as pointed out by Greg
>   Kroah-Hartman
> * Used devm functions as suggested by Keith Busch
> * Added a handful of sysfs attributes to the switchtec class
> * Added a handful of IOCTLs to the switchtec device
> * A number of miscellaneous bug fixes

I didn't audit the ioctl code, but the driver model and sysfs stuff
looks sane to me, nice job cleaning it up.

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/4] New Microsemi PCI Switch Management Driver Logan Gunthorpe <logang@deltatee.com> - 2017-02-02 19:10 +0100
  [PATCH v2 1/4] MicroSemi Switchtec management interface driver Logan Gunthorpe <logang@deltatee.com> - 2017-02-02 19:10 +0100
    Re: [PATCH v2 1/4] MicroSemi Switchtec management interface driver Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-02-10 16:00 +0100
      Re: [PATCH v2 1/4] MicroSemi Switchtec management interface driver Logan Gunthorpe <logang@deltatee.com> - 2017-02-10 18:00 +0100
        Re: [PATCH v2 1/4] MicroSemi Switchtec management interface driver Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-02-10 18:00 +0100
          Re: [PATCH v2 1/4] MicroSemi Switchtec management interface driver Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-02-10 18:20 +0100
            Re: [PATCH v2 1/4] MicroSemi Switchtec management interface driver Logan Gunthorpe <logang@deltatee.com> - 2017-02-10 19:10 +0100
          Re: [PATCH v2 1/4] MicroSemi Switchtec management interface driver Logan Gunthorpe <logang@deltatee.com> - 2017-02-10 19:00 +0100
      [PATCH] switchtec: cleanup cdev init Logan Gunthorpe <logang@deltatee.com> - 2017-02-10 19:10 +0100
    Re: [PATCH v2 1/4] MicroSemi Switchtec management interface driver Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-02-10 16:00 +0100
  [PATCH v2 3/4] switchtec: Add sysfs attributes to the Switchtec driver Logan Gunthorpe <logang@deltatee.com> - 2017-02-02 19:10 +0100
    Re: [PATCH v2 3/4] switchtec: Add sysfs attributes to the Switchtec  driver Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-02-10 16:00 +0100
  [PATCH v2 2/4] switchtec: Add user interface documentation Logan Gunthorpe <logang@deltatee.com> - 2017-02-02 19:10 +0100
  [PATCH v2 4/4] switchtec: Add IOCTLs to the Switchtec driver Logan Gunthorpe <logang@deltatee.com> - 2017-02-02 19:10 +0100
  Re: [PATCH v2 0/4] New Microsemi PCI Switch Management Driver Wei Zhang <wzhang@fb.com> - 2017-02-10 00:20 +0100
    Re: [PATCH v2 0/4] New Microsemi PCI Switch Management Driver Wei Zhang <wzhang@fb.com> - 2017-02-10 00:50 +0100
  Re: [PATCH v2 0/4] New Microsemi PCI Switch Management Driver Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-02-10 16:00 +0100
  Re: [PATCH v2 0/4] New Microsemi PCI Switch Management Driver Jens Axboe <axboe@kernel.dk> - 2017-02-10 17:20 +0100

csiph-web