Re: [PATCH] security: use READ_ONCE instead of deprecated ACCESS_ONCE

From	David Howells <dhowells@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] security: use READ_ONCE instead of deprecated ACCESS_ONCE
Date	2017-02-10 12:30 +0100
Message-ID	<t9hyN-2L5-3@gated-at.bofh.it> (permalink)
References	<sFjO9-Ly-9@gated-at.bofh.it>
Organization	Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903

Show all headers | View raw

Davidlohr Bueso <dave@stgolabs.net> wrote:

> With the new standardized functions, we can replace all ACCESS_ONCE()
> calls across relevant security/keyrings/.
> 
> ACCESS_ONCE() does not work reliably on non-scalar types. For example
> gcc 4.6 and 4.7 might remove the volatile tag for such accesses during
> the SRA (scalar replacement of aggregates) step:
> 
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145
> 
> Update the new calls regardless of if it is a scalar type, this is
> cleaner than having three alternatives.
> 
> Signed-off-by: Davidlohr Bueso <dbueso@suse.de>

Applied.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] security: use READ_ONCE instead of deprecated ACCESS_ONCE David Howells <dhowells@redhat.com> - 2017-02-10 12:30 +0100

csiph-web