Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1578280

Re: [PATCH v2 1/4] ARM: pwm: sun4i: unification of register operations for support sun6i.

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

On Wed, Feb 08, 2017 at 07:41:55PM +0300, Волков Сергей wrote:
> Hello all,
> 
> >> This patch not introduce new features, just prepare code for
> >> adding sun6i PWM driver in next commits.
> >>
> >> A31 SoC have a different map of PWM registers than others ASoCs,
> >> but register bits purposes are very similar.
> >>
> >> This patch introduce set of register access routines, which
> >> are common for existing in driver ASoCs:
> >>  - ctl_rdy   - checks the ready bit of specified PWM channel,
> >>  - ctl_read  - reads value from control register of specified PWM
> channel,
> >>  - ctl_write - writes significant bits to control register of specified
> PWM channel,
> >>  - prd_read  - reads value from period register of specified PWM channel,
> >>  - prd_write - writes value to period register of specified PWM channel.
> >> Driver code redesigned to use the new routines.
> >
> > Why don't you use regmap for that?
> 
> First of all, i'm newbie and its my first patchset. I just remake
> what i see in the driver. I even don't suspect about use regmap
> here.

Don't worry, a review is here to point where things could be better,
which doesn't mean that you did wrong :)

> Second thing - i can't test these driver on all existing sunxi SoCs,
> i have only A31 and A20 based boards where only pwm0 is
> accessible. Huge redesign cause bigger chance to make a mistake.

Don't worry about that either. We have a good number of platforms
using the PWMs already. If there's something broken at some point,
we'll catch it as well.

> If you think regmap solution is a must, then i will do that. This
> will be a good experience for me.

Yes, this really should cover what you're trying to do here,
especially reg_field.

You can have a look at drivers/reset/sti/reset-syscfg.c if you want to
have a look at a rather simple driver using it.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/4] Add the Allwinner A31/A31s PWM driver lis8215@gmail.com - 2017-02-07 19:00 +0100
  [PATCH v2 2/4] ARM: pwm: sun4i: selectable prescaler table for support sun6i. lis8215@gmail.com - 2017-02-07 19:00 +0100
  [PATCH v2 1/4] ARM: pwm: sun4i: unification of register operations for support sun6i. lis8215@gmail.com - 2017-02-07 19:00 +0100
    Re: [PATCH v2 1/4] ARM: pwm: sun4i: unification of register  operations for support sun6i. Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-02-08 10:20 +0100
      Re: [PATCH v2 1/4] ARM: pwm: sun4i: unification of register  operations for support sun6i. Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-02-10 09:40 +0100

csiph-web