Re: [PATCH 2/6] tpm: export tpm2_flush_context_cmd

From	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/6] tpm: export tpm2_flush_context_cmd
Date	2017-02-10 08:50 +0100
Message-ID	<t9e7U-tH-31@gated-at.bofh.it> (permalink)
References	<t8ys1-84Y-7@gated-at.bofh.it> <t8ys1-84Y-13@gated-at.bofh.it> <t8EQN-3Ed-1@gated-at.bofh.it>
Organization	Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

Show all headers | View raw

On Wed, Feb 08, 2017 at 10:58:30AM -0700, Jason Gunthorpe wrote:
> >  /**
> > + * tpm2_flush_context_cmd() - execute a TPM2_FlushContext command
> > + * @chip: TPM chip to use
> > + * @payload: the key data in clear and encrypted form
> > + * @options: authentication values and other options
> > + *
> > + * Return: same as with tpm_transmit_cmd
> > + */
> > +void tpm2_flush_context_cmd(struct tpm_chip *chip, u32 handle,
> > +			    unsigned int flags)
> 
> Why did you move the function in the same file? Adding a prototype
> shouldn't require that..
> 
> Jason

To be logically positioned in the same way as it is in the header.

It cannot in-between the helper functions for tpm2_seal_trusted().

/Jarkko

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/6] tpm: export tpm2_flush_context_cmd Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-02-08 12:20 +0100
  Re: [PATCH 2/6] tpm: export tpm2_flush_context_cmd Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2017-02-08 19:10 +0100
    Re: [PATCH 2/6] tpm: export tpm2_flush_context_cmd Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-02-10 08:50 +0100

csiph-web