Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1578213

Re: [PATCH 1/3 v2 staging-next] android: Collect statistics from lowmemorykiller

Show all headers | View raw

On 02/09/2017 09:13 PM, Greg Kroah-Hartman wrote:
> On Thu, Feb 09, 2017 at 04:42:35PM +0100, peter enderborg wrote:
>> This collects stats for shrinker calls and how much
>> waste work we do within the lowmemorykiller.
>>
>> Signed-off-by: Peter Enderborg <peter.enderborg@sonymobile.com>
>> ---
>>  drivers/staging/android/Kconfig                 | 11 ++++
>>  drivers/staging/android/Makefile                |  1 +
>>  drivers/staging/android/lowmemorykiller.c       |  9 ++-
>>  drivers/staging/android/lowmemorykiller_stats.c | 85 +++++++++++++++++++++++++
>>  drivers/staging/android/lowmemorykiller_stats.h | 29 +++++++++
>>  5 files changed, 134 insertions(+), 1 deletion(-)
>>  create mode 100644 drivers/staging/android/lowmemorykiller_stats.c
>>  create mode 100644 drivers/staging/android/lowmemorykiller_stats.h
> What changed from v1?
Nothing. I thought I found the reason why my tabs are replaced by spaces in transport.

>> @@ -72,6 +73,7 @@ static unsigned long lowmem_deathpending_timeout;
>>  static unsigned long lowmem_count(struct shrinker *s,
>>                    struct shrink_control *sc)
>>  {
>> +    lmk_inc_stats(LMK_COUNT);
>>      return global_node_page_state(NR_ACTIVE_ANON) +
>>          global_node_page_state(NR_ACTIVE_FILE) +
>>          global_node_page_state(NR_INACTIVE_ANON) +
> Your email client is eating tabs and spitting out spaces, making this
> impossible to even consider being merged :(
>
> Please fix your email client, documentation for how to do so is in the
> kernel Documentation directory.
>
> thanks,
>
> greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3 staging-next] android: Lowmemmorykiller task tree peter enderborg <peter.enderborg@sonymobile.com> - 2017-02-09 14:40 +0100
  [PATCH 1/3 v2 staging-next] android: Collect statistics from  lowmemorykiller peter enderborg <peter.enderborg@sonymobile.com> - 2017-02-09 17:00 +0100
    Re: [PATCH 1/3 v2 staging-next] android: Collect statistics from  lowmemorykiller Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-02-09 21:40 +0100
      Re: [PATCH 1/3 v2 staging-next] android: Collect statistics from  lowmemorykiller peter enderborg <peter.enderborg@sonymobile.com> - 2017-02-10 08:20 +0100
  Re: [PATCH 0/3 staging-next] android: Lowmemmorykiller task tree Michal Hocko <mhocko@kernel.org> - 2017-02-10 11:30 +0100
    Re: [PATCH 0/3 staging-next] android: Lowmemmorykiller task tree peter enderborg <peter.enderborg@sonymobile.com> - 2017-02-13 16:50 +0100

csiph-web