Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1579130
| From | Guenter Roeck <linux@roeck-us.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH] clk: qcom: Do not drop device node twice |
| Date | 2017-02-12 00:10 +0100 |
| Message-ID | <t9OXL-6U8-1@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
of_find_node_by_name() drops the reference to a passed device node.
It is not necessary to drop it again, and doing so may result in the
device node being released prematurely.
Cc: Rob Herring <robh@kernel.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
drivers/clk/qcom/common.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/clk/qcom/common.c b/drivers/clk/qcom/common.c
index cfab7b400381..03f9d316f969 100644
--- a/drivers/clk/qcom/common.c
+++ b/drivers/clk/qcom/common.c
@@ -145,7 +145,6 @@ static int _qcom_cc_register_board_clk(struct device *dev, const char *path,
clocks_node = of_find_node_by_path("/clocks");
if (clocks_node)
node = of_find_node_by_name(clocks_node, path);
- of_node_put(clocks_node);
if (!node) {
fixed = devm_kzalloc(dev, sizeof(*fixed), GFP_KERNEL);
--
2.7.4
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
[PATCH] clk: qcom: Do not drop device node twice Guenter Roeck <linux@roeck-us.net> - 2017-02-12 00:10 +0100
csiph-web