Re: [PATCH] Staging: arch/x86/kernel/setup.c : fixed empty line style issue

From	Thomas Gleixner <tglx@linutronix.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Staging: arch/x86/kernel/setup.c : fixed empty line style issue
Date	2017-02-11 21:00 +0100
Message-ID	<t9LZT-4NZ-5@gated-at.bofh.it> (permalink)
References	<t9JOp-3xw-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, 11 Feb 2017, Kishore Karanala wrote:

> From: Kishore <kishore.karanala@gmail.com>
> 
> Fixed empty line style issue

What? There is no issue. These empty lines are entirely correct and
removing them is just hurting readability.

Thanks,

	tglx

> Signed-off-by: Kishore Karanala <kishore.karanala@gmail.com>
> ---
>  arch/x86/kernel/setup.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
> index 4cfba94..6d35649 100644
> --- a/arch/x86/kernel/setup.c
> +++ b/arch/x86/kernel/setup.c
> @@ -723,7 +723,6 @@ static void __init trim_snb_memory(void)
>  	 * already been reserved.
>  	 */
>  	memblock_reserve(0, 1<<20);
> -	
>  	for (i = 0; i < ARRAY_SIZE(bad_pages); i++) {
>  		if (memblock_reserve(bad_pages[i], PAGE_SIZE))
>  			printk(KERN_WARNING "failed to reserve 0x%08lx\n",
> @@ -815,7 +814,6 @@ static void __init trim_low_memory_range(void)
>  {
>  	memblock_reserve(0, ALIGN(reserve_low, PAGE_SIZE));
>  }
> -	
>  /*
>   * Dump out kernel offset information on panic.
>   */
> -- 
> 2.7.4
> 
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH]        Staging: arch/x86/kernel/setup.c :  fixed empty line style issue Kishore Karanala <kishore.karanala@gmail.com> - 2017-02-11 18:40 +0100
  Re: [PATCH] Staging: arch/x86/kernel/setup.c : fixed empty line  style issue Thomas Gleixner <tglx@linutronix.de> - 2017-02-11 21:00 +0100

csiph-web