Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1578970

Re: [PATCH] iio: 104-quad-8: Fix off-by-one error when addressing flag register

Show all headers | View raw

On 09/02/17 15:03, William Breathitt Gray wrote:
> The flag register is offset by 1 from the respective channel data
> register. This patch fixes an off-by-one error when attempting to read a
> channel flag register where the base address was not properly offset.
> 
> Fixes: 28e5d3bb0325 ("iio: 104-quad-8: Add IIO support for the ACCES 104-QUAD-8")
> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
Applied to the fixes-togreg-post-rc1 branch of iio.git
Clue to when this will go upstream is in the name ;)

Thanks,

Jonathan
> ---
>  drivers/iio/counter/104-quad-8.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/counter/104-quad-8.c b/drivers/iio/counter/104-quad-8.c
> index a5913e97945e..f9b8fc9ae13f 100644
> --- a/drivers/iio/counter/104-quad-8.c
> +++ b/drivers/iio/counter/104-quad-8.c
> @@ -76,7 +76,7 @@ static int quad8_read_raw(struct iio_dev *indio_dev,
>  			return IIO_VAL_INT;
>  		}
>  
> -		flags = inb(base_offset);
> +		flags = inb(base_offset + 1);
>  		borrow = flags & BIT(0);
>  		carry = !!(flags & BIT(1));
>  
> 

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] iio: 104-quad-8: Fix off-by-one error when addressing flag  register William Breathitt Gray <vilhelm.gray@gmail.com> - 2017-02-09 16:10 +0100
  Re: [PATCH] iio: 104-quad-8: Fix off-by-one error when addressing  flag register Jonathan Cameron <jic23@kernel.org> - 2017-02-11 10:50 +0100

csiph-web