Re: [PATCH v2 2/5] time: mark syscore_ops as __ro_after_init

From	Thomas Gleixner <tglx@linutronix.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/5] time: mark syscore_ops as __ro_after_init
Date	2017-02-11 10:30 +0100
Message-ID	<t9Cad-7mN-9@gated-at.bofh.it> (permalink)
References	<t9uPn-2IM-5@gated-at.bofh.it> <t9uPn-2IM-7@gated-at.bofh.it> <t9vs5-3b9-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, 10 Feb 2017, John Stultz wrote:

> On Fri, Feb 10, 2017 at 5:37 PM, Jess Frazelle <me@jessfraz.com> wrote:
> > Marked syscore_ops structs as __ro_after_init when register_syscore_ops was
> > called only during init. Most of the caller functions were already annotated as
> > __init.
> > unregister_syscore_ops() was never called on these ops.
> > This protects the data structure from accidental corruption.
> >
> > Suggested-by: Kees Cook <keescook@chromium.org>
> > Signed-off-by: Jess Frazelle <me@jessfraz.com>
> > Acked-by: Rik van Riel <riel@redhat.com>
> 
> Thanks for sending this out. Looks reasonable to me. I'll queue it for
> testing, targeting for 4.12.

NAK. See:

  http://lkml.kernel.org/r/alpine.DEB.2.20.1702110948030.3734@nanos

Thanks,

	tglx

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 2/5] time: mark syscore_ops as __ro_after_init Jess Frazelle <me@jessfraz.com> - 2017-02-11 02:40 +0100
  Re: [PATCH v2 2/5] time: mark syscore_ops as __ro_after_init John Stultz <john.stultz@linaro.org> - 2017-02-11 03:20 +0100
    Re: [PATCH v2 2/5] time: mark syscore_ops as __ro_after_init Thomas Gleixner <tglx@linutronix.de> - 2017-02-11 10:30 +0100

csiph-web