Re: [PATCH 1/2] hyperv: implement hv_get_tsc_page()

From	Stephen Hemminger <stephen@networkplumber.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] hyperv: implement hv_get_tsc_page()
Date	2017-02-10 00:20 +0100
Message-ID	<t96am-42G-33@gated-at.bofh.it> (permalink)
References	<t8XJL-7cN-7@gated-at.bofh.it> <t8XJM-7cN-27@gated-at.bofh.it> <t93ct-2cm-5@gated-at.bofh.it> <t93ma-2fX-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 9 Feb 2017 21:14:25 +0100 (CET)
Thomas Gleixner <tglx@linutronix.de> wrote:

> On Thu, 9 Feb 2017, Stephen Hemminger wrote:
> 
> > The actual code looks fine, but the style police will not like you.
> > { should be at start of line on functions.
> > And #else should be at start of line,
> > 
> > But maybe this was just more of exchange mangling the mail.  
> 
> Looks like.
> 
> > +struct ms_hyperv_tsc_page *hv_get_tsc_page(void) {
> > +	return tsc_pg;
> > +}
> > +  
> 
> That's how it reads in a proper mail client connected to a proper mail
> server:
> 
> > +struct ms_hyperv_tsc_page *hv_get_tsc_page(void)
> > +{
> > +       return tsc_pg;
> > +}  
> 
> :)


Yup. it looks like the mail server is trying to be "helpful" by eliminating extra white space.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] x86/vdso: Add Hyper-V TSC page clocksource support Vitaly Kuznetsov <vkuznets@redhat.com> - 2017-02-09 15:20 +0100
  [PATCH 1/2] hyperv: implement hv_get_tsc_page() Vitaly Kuznetsov <vkuznets@redhat.com> - 2017-02-09 15:20 +0100
    RE: [PATCH 1/2] hyperv: implement hv_get_tsc_page() Stephen Hemminger <sthemmin@microsoft.com> - 2017-02-09 21:10 +0100
      RE: [PATCH 1/2] hyperv: implement hv_get_tsc_page() Thomas Gleixner <tglx@linutronix.de> - 2017-02-09 21:20 +0100
        Re: [PATCH 1/2] hyperv: implement hv_get_tsc_page() Stephen Hemminger <stephen@networkplumber.org> - 2017-02-10 00:20 +0100

csiph-web