Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1578060

Re: [PATCH V2] PCI: enable extended tags support for PCIe devices

From Sinan Kaya <okaya@codeaurora.org>
Newsgroups linux.kernel
Subject Re: [PATCH V2] PCI: enable extended tags support for PCIe devices
Date 2017-02-10 01:00 +0100
Message-ID <t96N3-4gQ-9@gated-at.bofh.it> (permalink)
References <t1IcO-8iP-27@gated-at.bofh.it> <t96tH-49k-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 2/9/2017 6:33 PM, Bjorn Helgaas wrote:
> Applied to pci/enumeration for v4.11 as follows, thanks!
> 
> I added a check for PCIe, so we don't have to rely on
> pcie_capability_read_dword() doing the right thing for PCI and PCI-X
> devices.  I think pcie_capability_read_dword() would set dev_cap to zero
> and return zero, which would be safe, but I don't the reader should have to
> do that much analysis to figure it out.

Thanks for cleaning up the commit message and adding the pci_is_pcie check.

-- 
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

Re: [PATCH V2] PCI: enable extended tags support for PCIe devices Bjorn Helgaas <helgaas@kernel.org> - 2017-02-10 00:40 +0100
  Re: [PATCH V2] PCI: enable extended tags support for PCIe devices Sinan Kaya <okaya@codeaurora.org> - 2017-02-10 01:00 +0100

csiph-web