Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1577992

Re: [PATCH net v3 1/2] net: ethernet: bgmac: init sequence bug

Show all headers | View raw

From: Jon Mason <jon.mason@broadcom.com>
Date: Wed,  8 Feb 2017 16:12:56 -0500

> The code now checks to see if the adapter needs to be brought out of
> reset (where as before it was doing an IDM write to bring it out of
> reset regardless of whether it was in reset or not).  Also, removed
> unnecessary usleeps (as there is already a read present to flush the
> IDM writes).

That's not what the delays are there for, I don't think you can
safely remove them.

It's for waiting for the reset to complete after the write to
the register has propagated by the read back.

Please retain the delays.

Thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net v3 1/2] net: ethernet: bgmac: init sequence bug Jon Mason <jon.mason@broadcom.com> - 2017-02-08 22:20 +0100
  Re: [PATCH net v3 1/2] net: ethernet: bgmac: init sequence bug David Miller <davem@davemloft.net> - 2017-02-09 23:20 +0100

csiph-web